Speedup individual CsvIt spec execution#145869
Merged
idegtiarenko merged 4 commits intoelastic:mainfrom Apr 9, 2026
Merged
Conversation
idegtiarenko
added
>test
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
idegtiarenko
commented
Apr 8, 2026
| nodeConfigDir = createConfigDir(); | ||
| long start = System.currentTimeMillis(); | ||
| logger.info("Creating test cluster"); | ||
| var nodeDirectory = createTempDir(); |
Contributor
Author
There was a problem hiding this comment.
createTempDir() proved to be expensive in #145543
This reuses single temp dir rather than having a separate one for configuration.
idegtiarenko
commented
Apr 8, 2026
| new PlannerSettings.Holder(clusterService), | ||
| CrossProjectModeDecider.NOOP | ||
| ); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
CsvIT uses EsqlTestUtils#classpathResources in order to discover and load spec files.
Since EsqlTestUtils has to be laoded above static block was executed as well, initializing number of non trivial but unused dependencies adding ~1s (highlighted in the profile below) to initialization duration on my machine. Moving this code to its only usage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements couple of distinct changes that could speedup test initialization in CsvIt