Skip to content

[ML] Call old inference API #145690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
prwhelan merged 3 commits into from
Apr 8, 2026
+19 −3
Merged

[ML] Call old inference API #145690

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a53afc0
[ML] Call old inference API
prwhelan Apr 3, 2026
60b7301
Merge branch 'main' into fix/145511
prwhelan Apr 3, 2026
521bf7e
Merge branch 'main' into fix/145511
prwhelan Apr 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 19 additions & 3 deletions ...aRestTest/java/org/elasticsearch/xpack/restart/MLModelDeploymentFullClusterRestartIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,13 @@ public void testDeploymentSurvivesRestart() throws Exception {
putModelDefinition(modelId);
putVocabulary(List.of("these", "are", "my", "words"), modelId);
startDeployment(modelId);
assertInfer(modelId);
assertBusy(() -> {
try {
assertInfer(modelId);
} catch (ResponseException e) {
throw new AssertionError("Inference failed on old cluster", e);
}
}, 90, TimeUnit.SECONDS);
} else {
ensureHealth(".ml-inference-*,.ml-config*", (request -> {
request.addParameter("wait_for_status", "yellow");
Expand Down Expand Up @@ -141,7 +147,10 @@ private void waitForDeploymentStarted(String modelId) throws Exception {

private void assertInfer(String modelId) throws IOException {
Response inference = infer("my words", modelId);
assertThat(EntityUtils.toString(inference.getEntity()), equalTo("{\"inference_results\":[{\"predicted_value\":[[1.0,1.0]]}]}"));
String expectedResponse = oldClusterHasInferEndpoint()
? "{\"inference_results\":[{\"predicted_value\":[[1.0,1.0]]}]}"
: "{\"predicted_value\":[[1.0,1.0]]}";
assertThat(EntityUtils.toString(inference.getEntity()), equalTo(expectedResponse));
}

private void putModelDefinition(String modelId) throws IOException {
Expand Down Expand Up @@ -232,8 +241,15 @@ private Response getTrainedModelStats(String modelId) throws IOException {
return response;
}

private boolean oldClusterHasInferEndpoint() {
return isRunningAgainstOldCluster() == false || getOldClusterTestVersion().onOrAfter("8.3.0");
}

private Response infer(String input, String modelId) throws IOException {
Request request = new Request("POST", "/_ml/trained_models/" + modelId + "/_infer");
String endpoint = oldClusterHasInferEndpoint()
? "/_ml/trained_models/" + modelId + "/_infer"
: "/_ml/trained_models/" + modelId + "/deployment/_infer?timeout=30s";
Request request = new Request("POST", endpoint);
request.setJsonEntity(Strings.format("""
{ "docs": [{"input":"%s"}] }
""", input));
Expand Down
Loading