PromQL: validate counter metric compatibility with functions in postAnalysisVerification#145547
Merged
felixbarny merged 5 commits intoelastic:mainfrom Apr 3, 2026
Merged
Conversation
…nalysisVerification Within-series functions like avg_over_time, delta, etc. do not support counter metrics in the current ES|QL implementation. Conversely, rate/increase/irate only accept counter metrics. Previously, these mismatches caused 5xx errors during translation (QlIllegalArgumentException). This change catches them early in postAnalysisVerification, producing clear user-facing errors. Adds a CounterSupport enum to PromqlFunctionRegistry.FunctionDefinition that classifies each function as REQUIRED (counter-only), SUPPORTED (both), or UNSUPPORTED (non-counter only). The validation only checks functions whose direct child is a RangeSelector, because InstantSelectors are implicitly wrapped in LastOverTime during translation, which converts counter types to their numeric base types.
felixbarny
added
>non-issue
external-contributor
felixbarny
added
Team:StorageEngine
v9.4.0
:StorageEngine/PromQL
Collaborator
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
kkrik-es
approved these changes
Apr 2, 2026
mromaios
pushed a commit
to mromaios/elasticsearch
that referenced
this pull request
Apr 9, 2026
…nalysisVerification (elastic#145547) Within-series functions like avg_over_time, delta, etc. do not support counter metrics in the current ES|QL implementation. Conversely, rate/increase/irate only accept counter metrics. Previously, these mismatches caused 5xx errors during translation (QlIllegalArgumentException). This change catches them early in postAnalysisVerification, producing clear user-facing errors. Adds a CounterSupport enum to PromqlFunctionRegistry.FunctionDefinition that classifies each function as REQUIRED (counter-only), SUPPORTED (both), or UNSUPPORTED (non-counter only). The validation only checks functions whose direct child is a RangeSelector, because InstantSelectors are implicitly wrapped in LastOverTime during translation, which converts counter types to their numeric base types.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Within-series functions like
avg_over_time,delta, etc. do not support counter metrics in the current ES|QL implementation. Conversely,rate/increase/irateonly accept counter metrics. Previously, these mismatches caused 5xx errors during translation (QlIllegalArgumentException). This change catches them early inpostAnalysisVerification, producing clear user-facing errors.CounterSupportenum toPromqlFunctionRegistry.FunctionDefinitionthat classifies each function asREQUIRED(counter-only),SUPPORTED(both), orUNSUPPORTED(non-counter only)RangeSelector, becauseInstantSelectors are implicitly wrapped inLastOverTimeduring translation, which converts counter types to their numeric base types