PromQL: assert output() is called on resolved plans in AcrossSeriesAggregate#145525
Merged
felixbarny merged 1 commit intoelastic:mainfrom Apr 2, 2026
Merged
Conversation
…gregate Encodes the contract from QueryPlan#output() with an assert rather than silently accepting unresolved attributes in the output stream. Relates: elastic#145307
felixbarny
added
>non-issue
v9.4.0
:StorageEngine/PromQL
elasticsearchmachine
added
Team:StorageEngine
external-contributor
Collaborator
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
alex-spies
approved these changes
Apr 2, 2026
Contributor
alex-spies
left a comment
alex-spies
left a comment
There was a problem hiding this comment.
This is cool, thanks @felixbarny !
felixbarny
added a commit
to felixbarny/elasticsearch
that referenced
this pull request
Apr 2, 2026
…SeriesAggregate (elastic#145525)" The assert caused EsqlNodeSubclassTests to fail because those tests call output() on plans with unresolved children by design. Restores the original resolved() guard in the filter instead. Fixes elastic#145581, elastic#145583, elastic#145584, elastic#145585
mromaios
pushed a commit
to mromaios/elasticsearch
that referenced
this pull request
Apr 9, 2026
…gregate (elastic#145525) Encodes the contract from QueryPlan#output() with an assert rather than silently accepting unresolved attributes in the output stream. Relates: elastic#145307
mromaios
pushed a commit
to mromaios/elasticsearch
that referenced
this pull request
Apr 9, 2026
…SeriesAggregate (elastic#145525)" (elastic#145597) The assert caused EsqlNodeSubclassTests to fail because those tests call output() on plans with unresolved children by design. Restores the original resolved() guard in the filter instead. Fixes elastic#145581, elastic#145583, elastic#145584, elastic#145585, elastic#145594, elastic#145595, elastic#145601
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Encodes the contract from
QueryPlan#output()with an assert rather than silently accepting unresolved attributes in the output stream.Relates to alex-spies' comment in #145307.