Skip to content

ESQL: Solves CsvIT stats*WithOverFlowRow failing#145434

Merged
ncordon merged 3 commits intoelastic:mainfrom
ncordon:stats-overflow-csvit-fix
Apr 1, 2026
Merged

ESQL: Solves CsvIT stats*WithOverFlowRow failing#145434
ncordon merged 3 commits intoelastic:mainfrom
ncordon:stats-overflow-csvit-fix

Conversation

@ncordon
Copy link
Copy Markdown
Member

@ncordon ncordon commented Apr 1, 2026

Closes #145415, closes #145424

The tests were showing null exception strings:

expected "Line 3:20: java.lang.ArithmeticException: long overflow" 
 but was "Line 3:20: java.lang.ArithmeticException: null"

The -XX:-OmitStackTraceInFastThrow JVM flag was added to the test task (line 149) by PR #134910, but not to the internalClusterTest task (line 316). CsvIT runs as an internalClusterTest, this pr adds the flag to the correct gradle task.

@ncordon ncordon added >bug Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) :Analytics/ES|QL AKA ESQL v9.4.0 labels Apr 1, 2026
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 1, 2026

🔍 Preview links for changed docs

⏳ Building and deploying preview... View progress

This comment will be updated with preview links when the build is complete.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 1, 2026

ℹ️ Important: Docs version tagging

👋 Thanks for updating the docs! Just a friendly reminder that our docs are now cumulative. This means all 9.x versions are documented on the same page and published off of the main branch, instead of creating separate pages for each minor version.

We use applies_to tags to mark version-specific features and changes.

Expand for a quick overview

When to use applies_to tags:

✅ At the page level to indicate which products/deployments the content applies to (mandatory)
✅ When features change state (e.g. preview, ga) in a specific version
✅ When availability differs across deployments and environments

What NOT to do:

❌ Don't remove or replace information that applies to an older version
❌ Don't add new information that applies to a specific version without an applies_to tag
❌ Don't forget that applies_to tags can be used at the page, section, and inline level

🤔 Need help?

Copy link
Copy Markdown
Contributor

@alex-spies alex-spies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

@ncordon ncordon enabled auto-merge (squash) April 1, 2026 16:09
@ncordon ncordon merged commit 91e8c04 into elastic:main Apr 1, 2026
33 of 35 checks passed
mromaios pushed a commit to mromaios/elasticsearch that referenced this pull request Apr 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Analytics/ES|QL AKA ESQL >bug Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v9.4.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI] CsvIT test {csv-spec:stats.sumAsSurrogateWithOverflowRow} failing CsvIT stats*WithOverFlowRow failing

3 participants