Skip to content

Only use MemorySegment scorers when slices can be obtained from the IndexInput#145343

Merged
jimczi merged 4 commits intoelastic:mainfrom
thecoop:check-memorysegment-slices
Mar 31, 2026
Merged

Only use MemorySegment scorers when slices can be obtained from the IndexInput#145343
jimczi merged 4 commits intoelastic:mainfrom
thecoop:check-memorysegment-slices

Conversation

@thecoop
Copy link
Copy Markdown
Member

@thecoop thecoop commented Mar 31, 2026

Uses the fallback behaviour to single-scoring bulk implementations modified by #141718 (with interactions with #141762 too)

@thecoop thecoop requested a review from benwtrent March 31, 2026 15:44
@benwtrent benwtrent added auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) and removed WIP labels Mar 31, 2026
@elasticsearchmachine elasticsearchmachine added the Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch label Mar 31, 2026
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-search-relevance (Team:Search Relevance)

@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

Hi @thecoop, I've created a changelog YAML for you.

@github-actions
Copy link
Copy Markdown
Contributor

🔍 Preview links for changed docs

⏳ Building and deploying preview... View progress

This comment will be updated with preview links when the build is complete.

@github-actions
Copy link
Copy Markdown
Contributor

ℹ️ Important: Docs version tagging

👋 Thanks for updating the docs! Just a friendly reminder that our docs are now cumulative. This means all 9.x versions are documented on the same page and published off of the main branch, instead of creating separate pages for each minor version.

We use applies_to tags to mark version-specific features and changes.

Expand for a quick overview

When to use applies_to tags:

✅ At the page level to indicate which products/deployments the content applies to (mandatory)
✅ When features change state (e.g. preview, ga) in a specific version
✅ When availability differs across deployments and environments

What NOT to do:

❌ Don't remove or replace information that applies to an older version
❌ Don't add new information that applies to a specific version without an applies_to tag
❌ Don't forget that applies_to tags can be used at the page, section, and inline level

🤔 Need help?

@jimczi jimczi merged commit ca05edb into elastic:main Mar 31, 2026
35 checks passed
@thecoop thecoop deleted the check-memorysegment-slices branch March 31, 2026 21:55
ncordon pushed a commit to ncordon/elasticsearch that referenced this pull request Apr 1, 2026
…ndexInput (elastic#145343)

* Only use MemorySegment scorers when slices can be obtained from the IndexInput

---------

Co-authored-by: Benjamin Trent <ben.w.trent@gmail.com>
jimczi added a commit that referenced this pull request Apr 1, 2026
…ndexInput (#145369)

Only use MemorySegment scorers when slices can be obtained from the IndexInput (#145343)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) >bug :Search Relevance/Vectors Vector search Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch v9.4.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants