Add native int4 operation benchmarks; fix JDK22+ test guards#145096
Merged
john-wagster merged 5 commits intoelastic:mainfrom Mar 28, 2026
Merged
Add native int4 operation benchmarks; fix JDK22+ test guards#145096john-wagster merged 5 commits intoelastic:mainfrom
john-wagster merged 5 commits intoelastic:mainfrom
Conversation
…corerInt4 benchmark tests to run only on JDK22+, as the native scorer requires that.
Collaborator
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
…rks-and-tests-adjustment
thecoop
approved these changes
Mar 27, 2026
ChrisHegarty
approved these changes
Mar 27, 2026
Contributor
|
retried serverless checks a couple of times; there's a PR to fix the failing test in flight: https://github.com/elastic/elasticsearch-serverless/pull/6048 merging. |
This was referenced Mar 28, 2026
Closed
Closed
[CI] VectorScorerInt4BulkBenchmarkTests testQueryRandomBulk {p0=DOT_PRODUCT p1=1024} failing
#145057
Closed
GalLalouche
pushed a commit
to GalLalouche/elasticsearch
that referenced
this pull request
Mar 29, 2026
…corerInt4 benchmark tests to run only on JDK22+, as the native scorer requires that. (elastic#145096) Co-authored-by: John Wagster <john.wagster@elastic.co>
mamazzol
pushed a commit
to mamazzol/elasticsearch
that referenced
this pull request
Mar 30, 2026
…corerInt4 benchmark tests to run only on JDK22+, as the native scorer requires that. (elastic#145096) Co-authored-by: John Wagster <john.wagster@elastic.co>
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nativeWithNativeSeg,nativeWithHeapSeg) toVectorScorerInt4OperationBenchmark, comparing native libvec int4 dot product against the scalar and Lucene implementationsMemorySegmentheap segment support (JDK 22+)VectorScorerInt4OperationBenchmarkTestsCross-check benchmark results (Mac, Apple M2)
These are just a local cross-check. Full benchmark results on cloud instances are in #144429 and #144649.
Test plan
VectorScorerInt4OperationBenchmarkTestspasses (new native assertions)VectorScorerInt4BenchmarkTestspasses (JDK22+ guard)VectorScorerInt4BulkBenchmarkTestspasses (JDK22+ guard)