[DiskBBQ] Fix index sorting on flush (2nd attempt)#145076
Merged
iverase merged 3 commits intoelastic:mainfrom Mar 27, 2026
Merged
[DiskBBQ] Fix index sorting on flush (2nd attempt)#145076iverase merged 3 commits intoelastic:mainfrom
iverase merged 3 commits intoelastic:mainfrom
Conversation
iverase
added
>bug
:Search Relevance/Vectors
elasticsearchmachine
added
v9.3.3
Team:Search Relevance
Collaborator
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
Collaborator
|
Hi @iverase, I've created a changelog YAML for you. |
benwtrent
approved these changes
Mar 27, 2026
| } else { | ||
| DocsWithFieldSet newDocsWithField = new DocsWithFieldSet(); | ||
| final int[] ordMap = new int[fieldVectorsWriter.getDocsWithFieldSet().cardinality()]; // new ord to old ord | ||
| KnnVectorsWriter.mapOldOrdToNewOrd(fieldVectorsWriter.getDocsWithFieldSet(), sortMap, null, ordMap, newDocsWithField); |
Member
There was a problem hiding this comment.
ah yeah! I forgot about this helper!
iverase
added
the
auto-backport
Collaborator
💔 Backport failedYou can use sqren/backport to manually backport by running |
This was referenced Mar 27, 2026
mamazzol
pushed a commit
to mamazzol/elasticsearch
that referenced
this pull request
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #144938, I was still seeing a strange behaviour when hitting restrictive filters. I improved the test for restrictive filters and I could reprodduce it. It seems the change was not enough so here is the next version which make test happy.