Prometheus label values API: add response listener#144957
Merged
felixbarny merged 5 commits intoelastic:mainfrom Mar 27, 2026
Merged
Prometheus label values API: add response listener#144957felixbarny merged 5 commits intoelastic:mainfrom
felixbarny merged 5 commits intoelastic:mainfrom
Conversation
Converts an EsqlQueryResponse into the Prometheus label values JSON format, handling prefix stripping, truncation detection, and unknown-column errors.
felixbarny
added
>non-issue
v9.4.0
:StorageEngine/PromQL
elasticsearchmachine
added
Team:StorageEngine
external-contributor
Collaborator
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
This was referenced Mar 25, 2026
kkrik-es
reviewed
Mar 26, 2026
...main/java/org/elasticsearch/xpack/prometheus/rest/PrometheusLabelValuesResponseListener.java
Show resolved
Hide resolved
kkrik-es
approved these changes
Mar 26, 2026
Member
kkrik-es
left a comment
kkrik-es
left a comment
There was a problem hiding this comment.
Just a comment about testing coverage, please take care of it before merging.
…es-api-response-listener
…es-api-response-listener
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
PrometheusLabelValuesResponseListener, which converts anEsqlQueryResponseinto the Prometheus label values JSON format, handling prefix stripping, truncation detection, and unknown-column errors. It is covered by unit tests inPrometheusLabelValuesResponseListenerTests.This is part of a stack implementing the Prometheus label values API endpoint:
Stacking order