Skip to content

Fix Int4 vector library tests failing on Java 21 #144830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChrisHegarty merged 8 commits into from
Mar 26, 2026
Merged

Fix Int4 vector library tests failing on Java 21 #144830

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
448c6b6
Fix Int4 vector library tests failing on Java 21
ChrisHegarty Mar 24, 2026
da954d1
Merge branch 'main' into fix/int4-vector-tests-heap-segment
ChrisHegarty Mar 24, 2026
8d67cae
Merge branch 'main' into fix/int4-vector-tests-heap-segment
ChrisHegarty Mar 24, 2026
75c2f36
Merge branch 'main' into fix/int4-vector-tests-heap-segment
ChrisHegarty Mar 24, 2026
5c267d1
Merge branch 'main' into fix/int4-vector-tests-heap-segment
ChrisHegarty Mar 24, 2026
f377fd7
Merge branch 'main' into fix/int4-vector-tests-heap-segment
ChrisHegarty Mar 25, 2026
b715a09
itr
ChrisHegarty Mar 25, 2026
0089f22
Merge branch 'main' into fix/int4-vector-tests-heap-segment
ChrisHegarty Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions libs/native/src/test/java/org/elasticsearch/nativeaccess/jdk/JDKVectorLibraryInt4Tests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,8 @@ public void testInt4Bulk() {
float[] expectedScores = new float[numVecs];
scalarSimilarityBulk(unpackedValues[queryOrd], packedValues, expectedScores);

var nativeQuerySeg = MemorySegment.ofArray(unpackedValues[queryOrd]);
var nativeQuerySeg = arena.allocate(dims);
MemorySegment.copy(unpackedValues[queryOrd], 0, nativeQuerySeg, ValueLayout.JAVA_BYTE, 0L, dims);
var bulkScoresSeg = arena.allocate((long) numVecs * Float.BYTES);
similarityBulk(packedSegment, nativeQuerySeg, packedLen, numVecs, bulkScoresSeg);
assertScoresEquals(expectedScores, bulkScoresSeg);
Expand Down Expand Up @@ -162,7 +163,8 @@ public void testInt4BulkWithOffsets() {
float[] expectedScores = new float[numVecs];
scalarSimilarityBulkWithOffsets(unpackedValues[queryOrd], packedValues, offsets, expectedScores);

var nativeQuerySeg = MemorySegment.ofArray(unpackedValues[queryOrd]);
var nativeQuerySeg = arena.allocate(dims);
MemorySegment.copy(unpackedValues[queryOrd], 0, nativeQuerySeg, ValueLayout.JAVA_BYTE, 0L, dims);
var bulkScoresSeg = arena.allocate((long) numVecs * Float.BYTES);

similarityBulkWithOffsets(packedSegment, nativeQuerySeg, packedLen, packedLen, offsetsSegment, numVecs, bulkScoresSeg);
Expand Down Expand Up @@ -195,7 +197,8 @@ public void testInt4BulkWithOffsetsAndPitch() {
float[] expectedScores = new float[numVecs];
scalarSimilarityBulkWithOffsets(unpackedValues[queryOrd], packedValues, offsets, expectedScores);

var nativeQuerySeg = MemorySegment.ofArray(unpackedValues[queryOrd]);
var nativeQuerySeg = arena.allocate(dims);
MemorySegment.copy(unpackedValues[queryOrd], 0, nativeQuerySeg, ValueLayout.JAVA_BYTE, 0L, dims);
var bulkScoresSeg = arena.allocate((long) numVecs * Float.BYTES);

similarityBulkWithOffsets(packedSegment, nativeQuerySeg, packedLen, pitch, offsetsSegment, numVecs, bulkScoresSeg);
Expand Down
Loading