Fix BWC regression: int4 vector types drop confidence_interval after Lucene 10.4 upgrade#144673
Closed
tballison wants to merge 7 commits intoelastic:mainfrom
Closed
Fix BWC regression: int4 vector types drop confidence_interval after Lucene 10.4 upgrade#144673tballison wants to merge 7 commits intoelastic:mainfrom
tballison wants to merge 7 commits intoelastic:mainfrom
Conversation
elasticsearchmachine
added
external-contributor
tballison
added
medium-risk
elasticsearchmachine
added
the
Team:Search Relevance
Collaborator
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
elasticsearchmachine
removed
the
needs:triage
Member
benwtrent
reviewed
Mar 20, 2026
Comment on lines
+3544
to
+3546
| // 0.0 (dynamic quantiles) is the old default; suppress deprecation noise on BWC round-trips. | ||
| boolean shouldWarn = indexVersion.onOrAfter(IndexVersions.UPGRADE_TO_LUCENE_10_4_0) | ||
| && confidenceInterval != 0.0f; |
Member
There was a problem hiding this comment.
How do we still warn for users who directly provide confidence_interval 0?
Contributor
Author
There was a problem hiding this comment.
Y, that's my other concern. We can't set a sentinel -1 because that would break validation. I certainly don't want to add a separate confidence_interval_explicitly_set. Same warning no matter the value? Or maybe diff warning if 0.0?
tballison
commented
Mar 20, 2026
| builder.field("confidence_interval", confidenceInterval); | ||
| } | ||
| // Always write for BWC: pre-Lucene-10.4 nodes expect confidence_interval to be present. | ||
| builder.field("confidence_interval", confidenceInterval != null ? confidenceInterval : 0.0f); |
Contributor
Author
There was a problem hiding this comment.
I don't think there are any side-effects from injecting 0.0 when null, but please review this carefully.
Collaborator
|
Hi @tballison, I've created a changelog YAML for you. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See title.
This should fix: #143980