Add missing testBulkIllegalDims for INT8 and FLOAT32#144639
Merged
ChrisHegarty merged 1 commit intoelastic:mainfrom Mar 20, 2026
Merged
Add missing testBulkIllegalDims for INT8 and FLOAT32#144639ChrisHegarty merged 1 commit intoelastic:mainfrom
ChrisHegarty merged 1 commit intoelastic:mainfrom
Conversation
ChrisHegarty
added
>test
Collaborator
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
benwtrent
approved these changes
Mar 20, 2026
ldematte
approved these changes
Mar 20, 2026
Contributor
ldematte
left a comment
ldematte
left a comment
There was a problem hiding this comment.
👍 thanks for covering this!
michalborek
pushed a commit
to michalborek/elasticsearch
that referenced
this pull request
Mar 23, 2026
While working on bulk sparse scoring (elastic#144557), I noticed that INT8 and FLOAT32 were missing testBulkIllegalDims coverage that INT7U, INT4, and BBQ already have. Extracting this into a small targeted PR. Both new tests verify IOOBE for count overflow, negative count, negative dims, and undersized result buffer, matching the existing pattern in JDKVectorLibraryInt7uTests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on bulk sparse scoring (#144557), I noticed that INT8 and FLOAT32 were missing
testBulkIllegalDimscoverage that INT7U, INT4, and BBQ already have. Extracting this into a small targeted PR.Both new tests verify IOOBE for count overflow, negative count, negative dims, and undersized result buffer, matching the existing pattern in
JDKVectorLibraryInt7uTests.