Skip to content

Use marked repository name in DataStreamLifecycleConvertToFrozen#144511

Merged
dakrone merged 9 commits intoelastic:mainfrom
dakrone:dlm-use-marked-repo
Mar 26, 2026
Merged

Use marked repository name in DataStreamLifecycleConvertToFrozen#144511
dakrone merged 9 commits intoelastic:mainfrom
dakrone:dlm-use-marked-repo

Conversation

@dakrone
Copy link
Copy Markdown
Member

@dakrone dakrone commented Mar 18, 2026

As a result of #144248 we mark the repository name to use for frozen conversion in the custom metadata of the backing index, so that a consistent repository is used for the whole process. This commit enhances the conversion faculties to use this repository name.

As a result of elastic#144248 we mark the repository name to use for frozen conversion in the custom metadata of the backing index, so that a consistent repository is used for the whole process. This commit enhances the conversion faculties to use this repository name.
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-storage-engine (Team:StorageEngine)

Copy link
Copy Markdown
Contributor

@lukewhiting lukewhiting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

Copy link
Copy Markdown
Contributor

@lukewhiting lukewhiting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checking the CI, looks like ES fails to actually start with the error:

[2026-03-19T07:23:04,037][ERROR][o.e.b.Elasticsearch ] [test-cluster-2] fatal exception while booting Elasticsearch java.lang.IllegalStateException: Plugin [dlm-frozen-transition] cannot extend non-extensible plugin [data-streams]

@dakrone
Copy link
Copy Markdown
Member Author

dakrone commented Mar 19, 2026

Checking the CI, looks like ES fails to actually start with the error:

Yep, this needs the new module in x-pack in order to work correctly, once that is in I'll adjust this and it should pass.

Copy link
Copy Markdown
Contributor

@seanzatzdev seanzatzdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@dakrone dakrone requested a review from lukewhiting March 26, 2026 16:45
Copy link
Copy Markdown
Contributor

@lukewhiting lukewhiting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@dakrone dakrone enabled auto-merge (squash) March 26, 2026 16:47
@dakrone dakrone merged commit 14c5e79 into elastic:main Mar 26, 2026
36 checks passed
mamazzol pushed a commit to mamazzol/elasticsearch that referenced this pull request Mar 30, 2026
…lastic#144511)

* Use marked repository name in `DataStreamLifecycleConvertToFrozen`

As a result of elastic#144248 we mark the repository name to use for frozen conversion in the custom metadata of the backing index, so that a consistent repository is used for the whole process. This commit enhances the conversion faculties to use this repository name.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants