Refactor DataStream.getIndicesOlderThan to return a Set#144422
Merged
dakrone merged 7 commits intoelastic:mainfrom Mar 18, 2026
Merged
Refactor DataStream.getIndicesOlderThan to return a Set#144422dakrone merged 7 commits intoelastic:mainfrom
dakrone merged 7 commits intoelastic:mainfrom
Conversation
Previously this method returned a list of indices, but it now returns a set. These indices don't actually need to be iterated in order for the DLM actions. Relates to elastic#144248 (comment)
dakrone
added
>non-issue
:StorageEngine/Data streams
Collaborator
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
lukewhiting
reviewed
Mar 17, 2026
...s/src/test/java/org/elasticsearch/datastreams/lifecycle/DataStreamLifecycleServiceTests.java
Outdated
Show resolved
Hide resolved
michalborek
pushed a commit
to michalborek/elasticsearch
that referenced
this pull request
Mar 23, 2026
* Refactor DataStream.getIndicesOlderThan to return a Set Previously this method returned a list of indices, but it now returns a set. These indices don't actually need to be iterated in order for the DLM actions. Relates to elastic#144248 (comment) * Return unmodifiable set to be consistent * Now that it's immutable, we need a mutable version in DLM service * [CI] Auto commit changes from spotless --------- Co-authored-by: elasticsearchmachine <infra-root+elasticsearchmachine@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously this method returned a list of indices, but it now returns a set. These indices don't actually need to be iterated in order for the DLM actions.
Relates to #144248 (comment)