Remove cleanup shutdown hook from APMJvmOptions#144420
Merged
jfreden merged 2 commits intoelastic:patch/serverless-fixfrom Mar 18, 2026
Merged
Remove cleanup shutdown hook from APMJvmOptions#144420jfreden merged 2 commits intoelastic:patch/serverless-fixfrom
jfreden merged 2 commits intoelastic:patch/serverless-fixfrom
Conversation
mark-vieira
added
>non-issue
:Core/Infra/CLI
elasticsearchmachine
added
v9.4.0
Team:Core/Infra
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
mark-vieira
force-pushed
the
apm-config-file-fix
branch
from
9587ba4 to
22642db
Compare
Contributor
|
The serverless checks are failing due to production-canary. Is that related to the fact that production-canary is currently locked? Or is it a coincidence? |
Contributor
|
The pending |
JVerwolf
pushed a commit
to JVerwolf/elasticsearch
that referenced
this pull request
Mar 18, 2026
michalborek
pushed a commit
to michalborek/elasticsearch
that referenced
this pull request
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After the changes in #143712 the
ServerCliis no longer a long-lived process. This means that the shutdown hook here runs before Elasticsearch starts, deleting this configuration file too early. We actually don't need to do this cleanup at all, since ES will delete this file itself during node startup.