Prometheus: Build plumbing — widen PromqlCommand.STEP_COLUMN_NAME and add ES|QL deps to prometheus plugin#144301
Merged
felixbarny merged 4 commits intoelastic:mainfrom Mar 19, 2026
Merged
Conversation
felixbarny
added
>non-issue
Team:StorageEngine
v9.4.0
:StorageEngine/PromQL
Collaborator
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
elasticsearchmachine
added
the
external-contributor
This was referenced Mar 16, 2026
…s to prometheus plugin - Widen `PromqlCommand.STEP_COLUMN_NAME` from `private` to `public` so the Prometheus plugin can reference it without reflection. - Add `x-pack-esql` to `extendedPlugins` in prometheus/build.gradle so the plugin can depend on ES|QL classes at runtime. - Add `compileOnly` and `testImplementation` deps on `x-pack-esql` and `x-pack-esql-core` so the prometheus plugin can compile against ES|QL types.
felixbarny
force-pushed
the
promql-query-range-pr1
branch
from
6285044 to
c005a42
Compare
This was referenced Mar 16, 2026
sidosera
approved these changes
Mar 19, 2026
michalborek
pushed a commit
to michalborek/elasticsearch
that referenced
this pull request
Mar 23, 2026
…s to prometheus plugin (elastic#144301) - Widen `PromqlCommand.STEP_COLUMN_NAME` from `private` to `public` so the Prometheus plugin can reference it without reflection. - Add `x-pack-esql` to `extendedPlugins` in prometheus/build.gradle so the plugin can depend on ES|QL classes at runtime. - Add `compileOnly` and `testImplementation` deps on `x-pack-esql` and `x-pack-esql-core` so the prometheus plugin can compile against ES|QL types.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is PR 1 of 4 in a stacked series that adds the Prometheus
query_rangeendpoint.See the overview PR #144294 for context.
Two pure infrastructure changes with no behaviour change:
PromqlCommand.java: widensSTEP_COLUMN_NAMEfromprivatetopublicso the Prometheus plugin can reference it without reflection.prometheus/build.gradle: addsx-pack-esqltoextendedPluginsand addscompileOnly/testImplementationdeps onx-pack-esqlandx-pack-esql-coreso the Prometheus plugin can compile against ES|QL types.Stacking order
/api/v1/query_range) endpoint #144303