Skip to content

ES|QL: Add parameterized query support to PromQL parser #144293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
felixbarny merged 5 commits into from
Mar 19, 2026
Merged

ES|QL: Add parameterized query support to PromQL parser #144293

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a764b3d
Provide PromQL query as query param
felixbarny Mar 15, 2026
07ea57b
Add tests for PromQL parameterized query; also support ?query without…
felixbarny Mar 16, 2026
bc2afac
Support value=?query without parens; add null/type/blank validation
felixbarny Mar 16, 2026
a9179a1
Merge remote-tracking branch 'origin/main' into promql-param-query
felixbarny Mar 19, 2026
d70ab32
[CI] Auto commit changes from spotless
Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion x-pack/plugin/esql/src/main/antlr/parser/Promql.g4
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,9 @@
parser grammar Promql;

promqlCommand
: PROMQL promqlParam* (valueName ASSIGN)? LP promqlQueryPart+ RP
: PROMQL promqlParam* (valueName ASSIGN)? LP NAMED_OR_POSITIONAL_PARAM RP // ?param as the entire PromQL expression (parenthesized)
| PROMQL promqlParam* (valueName ASSIGN)? NAMED_OR_POSITIONAL_PARAM // ?param as the entire PromQL expression (unparenthesized)
| PROMQL promqlParam* (valueName ASSIGN)? LP promqlQueryPart+ RP
| PROMQL promqlParam* promqlQueryPart+
;

Expand Down
2 changes: 1 addition & 1 deletion x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/parser/EsqlBaseParser.interp
View file
Open in desktop

Large diffs are not rendered by default.

Loading
Loading