ESQL: Add generative tests for LIMIT BY #144238
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,148 @@ | ||
| /* | ||
| * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
| * or more contributor license agreements. Licensed under the Elastic License | ||
| * 2.0; you may not use this file except in compliance with the Elastic License | ||
| * 2.0. | ||
| */ | ||
|
|
||
| package org.elasticsearch.xpack.esql.generator.command.pipe; | ||
|
|
||
| import org.elasticsearch.xpack.esql.generator.Column; | ||
| import org.elasticsearch.xpack.esql.generator.EsqlQueryGenerator; | ||
| import org.elasticsearch.xpack.esql.generator.QueryExecutor; | ||
| import org.elasticsearch.xpack.esql.generator.command.CommandGenerator; | ||
|
|
||
| import java.util.ArrayList; | ||
| import java.util.HashMap; | ||
| import java.util.LinkedHashSet; | ||
| import java.util.List; | ||
| import java.util.Map; | ||
| import java.util.Set; | ||
|
|
||
| import static org.elasticsearch.test.ESTestCase.randomIntBetween; | ||
|
|
||
| public class LimitByGenerator implements CommandGenerator { | ||
| public static final CommandGenerator INSTANCE = new LimitByGenerator(); | ||
| public static final String LIMIT_BY = "limit_by"; | ||
|
|
||
| private static final String LIMIT_CONTEXT = "limit"; | ||
| private static final String GROUPINGS_CONTEXT = "groupings"; | ||
|
|
||
| @Override | ||
| public CommandDescription generate( | ||
| List<CommandDescription> previousCommands, | ||
| List<Column> previousOutput, | ||
| QuerySchema schema, | ||
| QueryExecutor executor | ||
| ) { | ||
| List<Column> groupable = previousOutput.stream() | ||
| .filter(EsqlQueryGenerator::groupable) | ||
| .filter(EsqlQueryGenerator::fieldCanBeUsed) | ||
| .toList(); | ||
| if (groupable.isEmpty()) { | ||
| return EMPTY_DESCRIPTION; | ||
| } | ||
|
|
||
| int limit = randomIntBetween(0, 100); | ||
| int groupingCount = randomIntBetween(1, Math.min(3, groupable.size())); | ||
| Set<String> groupings = new LinkedHashSet<>(); | ||
| for (int i = 0; i < groupingCount; i++) { | ||
| String col = EsqlQueryGenerator.randomGroupableName(groupable); | ||
| if (col != null) { | ||
| groupings.add(col); | ||
| } | ||
| } | ||
| if (groupings.isEmpty()) { | ||
| return EMPTY_DESCRIPTION; | ||
| } | ||
|
|
||
| String cmd = " | LIMIT " + limit + " BY " + String.join(", ", groupings); | ||
| return new CommandDescription(LIMIT_BY, this, cmd, Map.of(LIMIT_CONTEXT, limit, GROUPINGS_CONTEXT, List.copyOf(groupings))); | ||
| } | ||
|
|
||
| @Override | ||
| public ValidationResult validateOutput( | ||
| List<CommandDescription> previousCommands, | ||
| CommandDescription commandDescription, | ||
| List<Column> previousColumns, | ||
| List<List<Object>> previousOutput, | ||
| List<Column> columns, | ||
| List<List<Object>> output | ||
| ) { | ||
| int limit = (int) commandDescription.context().get(LIMIT_CONTEXT); | ||
|
|
||
| if (limit == 0 && output.isEmpty() == false) { | ||
| return new ValidationResult(false, "LIMIT 0 BY should return no rows, got [" + output.size() + "]"); | ||
|
Member
There was a problem hiding this comment. We are not checking
Contributor
Author
There was a problem hiding this comment. If any of them fail, we'll report a failure. We can check both things and make a composed message, but I think it's not worth it here (?) |
||
| } | ||
|
|
||
| ValidationResult columnsResult = CommandGenerator.expectSameColumns(previousCommands, previousColumns, columns); | ||
| if (columnsResult.success() == false) { | ||
| return columnsResult; | ||
| } | ||
|
|
||
| return validatePerGroupRowCounts(commandDescription, columns, output, limit); | ||
| } | ||
|
|
||
| @SuppressWarnings("unchecked") | ||
| private static ValidationResult validatePerGroupRowCounts( | ||
| CommandDescription commandDescription, | ||
| List<Column> columns, | ||
| List<List<Object>> output, | ||
| int limit | ||
| ) { | ||
| List<String> groupings = (List<String>) commandDescription.context().get(GROUPINGS_CONTEXT); | ||
|
|
||
| List<Integer> groupingIndices = new ArrayList<>(groupings.size()); | ||
| for (String grouping : groupings) { | ||
| String rawName = EsqlQueryGenerator.unquote(grouping); | ||
| int idx = -1; | ||
| for (int i = 0; i < columns.size(); i++) { | ||
| if (columns.get(i).name().equals(rawName)) { | ||
| idx = i; | ||
| break; | ||
| } | ||
| } | ||
| if (idx == -1) { | ||
| return new ValidationResult( | ||
| false, | ||
| "LIMIT " | ||
| + limit | ||
| + " BY: grouping column [" | ||
| + rawName | ||
| + "] was not found in the output schema. Available columns: " | ||
| + columns.stream().map(Column::name).toList() | ||
| ); | ||
| } | ||
| groupingIndices.add(idx); | ||
| } | ||
|
|
||
| Map<List<Object>, Integer> groupCounts = new HashMap<>(); | ||
| for (List<Object> row : output) { | ||
| List<Object> key = new ArrayList<>(groupingIndices.size()); | ||
| for (int idx : groupingIndices) { | ||
| Object value = row.get(idx); | ||
| key.add(value); | ||
| } | ||
| groupCounts.merge(key, 1, Integer::sum); | ||
| } | ||
|
|
||
| for (var entry : groupCounts.entrySet()) { | ||
| if (entry.getValue() > limit) { | ||
| return new ValidationResult( | ||
| false, | ||
| "LIMIT " | ||
| + limit | ||
| + " BY: group " | ||
| + entry.getKey() | ||
| + " has [" | ||
| + entry.getValue() | ||
| + "] rows, expected at most [" | ||
| + limit | ||
| + "]" | ||
| ); | ||
| } | ||
| } | ||
|
|
||
| return VALIDATION_OK; | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.