-
Notifications
You must be signed in to change notification settings - Fork 26.1k
ESQL: make unmapped_fields="load" automatically trigger for partially mapped KEYWORD fields, and allow projecting partially mapped non-KEYWORD fields #144228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
alex-spies
merged 88 commits into
elastic:main
from
alex-spies:fix-non-loaded-partially-mapped-fields
Apr 14, 2026
Merged
Changes from 19 commits
Commits
Show all changes
88 commits
Select commit
Hold shift + click to select a range
54c80ca
Add reproducer tests
alex-spies 80773ae
[CI] Auto commit changes from spotless
4d37592
WIP: check what cursor did there
alex-spies 5317911
Merge remote-tracking branch 'upstream/main' into fix-non-loaded-part…
alex-spies db02298
Update test
alex-spies c5c502f
Spotless
alex-spies 464c088
WIP
alex-spies c989926
WIP: more tests
alex-spies 65c765a
Add ability to unmap fields in CsvTestsDataLoader
alex-spies 8d058ca
Add employees_no_names index
alex-spies 9a2e72c
Fix, add tests
alex-spies a123267
Fix capabilities
alex-spies 773fad4
Don't mess with partially mapped non-KEYWORD fields at all
alex-spies fc29451
Add tests
alex-spies 631d8bc
Refactor a little
alex-spies 318e2a9
Merge branch 'main' into fix-non-loaded-partially-mapped-fields
alex-spies 821f3c4
Fix some tests
alex-spies b9ce17d
Fix CsvTests
alex-spies e96a952
Update capabilities
alex-spies fafe292
Spotless
alex-spies 59cd9fa
Improve comment
alex-spies 5f07932
Improve another comment
alex-spies 81f0205
More capability fixes
alex-spies 3484535
Remove redundant type override
alex-spies cecb383
Merge remote-tracking branch 'upstream/main' into fix-non-loaded-part…
alex-spies 3a6d552
Improve comment
alex-spies d67b210
Simplify loadPartiallyMappedKeywordFields
alex-spies 4daa8cd
More Andrei tests :)
alex-spies 7f81ee4
Small cleanup
alex-spies 0865f5d
Merge remote-tracking branch 'origin/main' into fix-non-loaded-partia…
mouhc1ne b7fe2ae
Merge remote-tracking branch 'origin/main' into fix-non-loaded-partia…
mouhc1ne 0fe03fd
[CI] Auto commit changes from spotless
0caffa7
Fix compile errors due to EsIndex signature change, missed during con…
mouhc1ne f05ad5f
Merge remote-tracking branch 'fork-alex/fix-non-loaded-partially-mapp…
mouhc1ne 4df3a71
Merge branch 'main' into fix-non-loaded-partially-mapped-fields
mouhc1ne edb3953
Remove duplicate no_mapping_sample_data
alex-spies 15f7260
Merge remote-tracking branch 'upstream/main' into fix-non-loaded-part…
alex-spies 24d608d
Fix capability
alex-spies eee9331
Update tests
alex-spies fa1c185
Move detection of PUNKs/PUKs to ResolveTable
alex-spies d3c8392
Make PUNKs unsupported for now
alex-spies 88090a3
Remove redundant tests
alex-spies 0f1a378
Merge remote-tracking branch 'upstream/main' into fix-non-loaded-part…
alex-spies 7bf841f
Update golden tests
alex-spies b328373
[CI] Auto commit changes from spotless
4e7aa3b
Merge remote-tracking branch 'upstream/main' into fix-non-loaded-part…
alex-spies 8b985b9
Load only the mapped data for PUNKs
alex-spies cc4ba1b
Put verification back in to avoid using PUNKs
alex-spies 43f3b9e
Fix golden tests
alex-spies c04ae5a
Small cleanup
alex-spies 661515d
Add capability
alex-spies 1981333
Fix error message
alex-spies fd3b6d0
Remove obsolete test
alex-spies 7124116
Fix test expectation
alex-spies 467d36b
Fix yaml tests
alex-spies 846be26
[CI] Auto commit changes from spotless
2bdb108
Fix capabilities in spec tests
alex-spies b9d00c3
Move new spec tests to unmapped-type-conflicts
alex-spies 8178c7f
Align test names
alex-spies cde5435
Add reproducer for #145206
alex-spies 1945de3
Merge remote-tracking branch 'upstream/main' into fix-non-loaded-part…
alex-spies c2d0abb
Merge branch 'main' into fix-non-loaded-partially-mapped-fields
alex-spies 30c05da
Merge remote-tracking branch 'upstream/main' into fix-non-loaded-part…
alex-spies 12fc233
Add tests with union types
alex-spies d7e680e
Add date/nanos tests
alex-spies b4ac2d3
Add tests without KEEP/DROP
alex-spies c3b4460
Fix capability
alex-spies b39181b
Add more golden tests
alex-spies 89f31af
More tests with KEEP + wildcard
alex-spies 26dadac
Another TS test
alex-spies d41f435
Tests with subfields
alex-spies 69b8b2b
[CI] Auto commit changes from spotless
e05eccd
Add test: conflict + PUNK in same EVAL
alex-spies 6288b50
Merge remote-tracking branch 'upstream/main' into fix-non-loaded-part…
alex-spies 4efaf41
Update docs/changelog/144228.yaml
alex-spies f06775a
Merge branch 'main' into fix-non-loaded-partially-mapped-fields
alex-spies 5262284
Improve comments
alex-spies 3ad660f
Merge branch 'main' into fix-non-loaded-partially-mapped-fields
mouhc1ne b12ba12
Merge remote-tracking branch 'upstream/main' into fix-non-loaded-part…
alex-spies 9a0e6b5
Fix some capability requirements
alex-spies e46e942
Fix some more tests
alex-spies 88e23ad
Fix last tests
alex-spies 143a74c
Fix one more spec test
alex-spies d8de54e
Merge remote-tracking branch 'upstream/main' into fix-non-loaded-part…
alex-spies 724c562
Whack one more test
alex-spies 86967b7
Merge remote-tracking branch 'upstream/main' into fix-non-loaded-part…
alex-spies d6791ae
And one more
alex-spies 08321ae
Last one, hopefully
alex-spies File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.