Skip to content

Return sentinel values from Fetch when sequence numbers are disabled#144212

Merged
elasticsearchmachine merged 2 commits intoelastic:mainfrom
romseygeek:seqno/sentinal-fetch
Mar 16, 2026
Merged

Return sentinel values from Fetch when sequence numbers are disabled#144212
elasticsearchmachine merged 2 commits intoelastic:mainfrom
romseygeek:seqno/sentinal-fetch

Conversation

@romseygeek
Copy link
Copy Markdown
Contributor

Rather than throwing an exception if sequence numbers are requested as
part of a search hit, we return the sentinel values if they have been disabled.

Relates to #136305

Rather than throwing an exception if sequence numbers are requested as
part of a search hit, we return the sentinel values if they have been
disabled.
@romseygeek romseygeek requested review from fcofdez, kkrik-es and tlrx March 13, 2026 15:29
@romseygeek romseygeek self-assigned this Mar 13, 2026
@elasticsearchmachine elasticsearchmachine added the Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch label Mar 13, 2026
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-search-relevance (Team:Search Relevance)

Copy link
Copy Markdown
Member

@tlrx tlrx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@fcofdez fcofdez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@romseygeek romseygeek added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Mar 13, 2026
@elasticsearchmachine elasticsearchmachine merged commit a4025b7 into elastic:main Mar 16, 2026
36 checks passed
@romseygeek romseygeek deleted the seqno/sentinal-fetch branch March 16, 2026 10:42
ncordon pushed a commit to ncordon/elasticsearch that referenced this pull request Mar 16, 2026
…lastic#144212)

Rather than throwing an exception if sequence numbers are requested as 
part of a search hit, we return the sentinel values if they have been
disabled.

Relates to elastic#136305
szybia added a commit to szybia/elasticsearch that referenced this pull request Mar 16, 2026
…elocations

* upstream/main: (33 commits)
  Unmute InferenceRestIT and DefaultEndPointsIT (elastic#144217)
  feat: add keep_alive to async task status (elastic#144010)
  Add explicit isNoOpUpdate() method to MapperService (elastic#144113)
  Always attach APM Agent (elastic#144120)
  Fix random_score nightly tests (elastic#144176)
  Add nested query checks for disabled sequence numbers (elastic#144185)
  Return sentinel values from Fetch when sequence numbers are disabled (elastic#144212)
  [Test] Test peer-recovery with sequence numbers pruning (elastic#144116)
  Remove `scaled-*` field assertions from mixed cluster downsampling test (elastic#144295)
  Refactor: Use range syntax in ES|QL exponential histogram tests (elastic#144110)
  Move resolve aliases to IndexAbstractionOptions (elastic#143953)
  unmute test (elastic#144299)
  Fix approximation csvtests (elastic#144233)
  fix test (elastic#144171)
  Add int4 vector scoring benchmarks (elastic#144105)
  Mute org.elasticsearch.xpack.esql.qa.single_node.GenerativeIT test elastic#143023
  Mute org.elasticsearch.test.apmintegration.MetricsApmIT testApmIntegration {withOTel=false} elastic#144282
  Native cli launcher (elastic#143712)
  Mute org.elasticsearch.xpack.esql.qa.multi_node.GenerativeIT test elastic#143023
  Mute org.elasticsearch.xpack.esql.heap_attack.HeapAttackSubqueryIT testManyRandomKeywordFieldsInSubqueryIntermediateResults elastic#144274
  ...
michalborek pushed a commit to michalborek/elasticsearch that referenced this pull request Mar 23, 2026
…lastic#144212)

Rather than throwing an exception if sequence numbers are requested as 
part of a search hit, we return the sentinel values if they have been
disabled.

Relates to elastic#136305
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) >non-issue :Search Relevance/Search Catch all for Search Relevance Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch v9.4.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants