Randomly disable sequence numbers in SimpleNestedIT#144093
Closed
romseygeek wants to merge 2 commits intoelastic:mainfrom
Closed
Randomly disable sequence numbers in SimpleNestedIT#144093romseygeek wants to merge 2 commits intoelastic:mainfrom
romseygeek wants to merge 2 commits intoelastic:mainfrom
Conversation
romseygeek
added
>non-issue
:StorageEngine/Mapping
Collaborator
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
kkrik-es
approved these changes
Mar 12, 2026
Member
|
Worth checking with |
Nested queries use entries in _primary_term docvalues fields to identify parent documents. This should not be affected by enabling or disabling sequence numbers, but to double check we now randomly change the sequence number setting in SimpleNestedIT.
We can't assumeTrue in method called during test setup.
romseygeek
force-pushed
the
seqno/nested-tests
branch
from
69b4ba7 to
7340d01
Compare
Contributor
Author
This actually found a bug in #144046 - have added a commit here which will fix it. |
Contributor
|
Maybe one thing that we should do in this test suite is to trigger merges too? otherwise we won't be trimming seq nos @romseygeek |
Contributor
Author
Oh, that's a very good point. I'll add some force merges to make sure pruning actually happens here. |
Contributor
Author
|
I'm going to close this one out and open a new PR with explicit tests for disabled sequence numbers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nested queries use entries in _primary_term docvalues fields to
identify parent documents. This should not be affected by enabling
or disabling sequence numbers, but to double check we now
randomly change the sequence number setting in SimpleNestedIT.