Skip to content

Remove AuthorizationTaskExecutorMultipleNodesIT#144042

Merged
dimitris-athanasiou merged 2 commits intoelastic:mainfrom
dimitris-athanasiou:remove-AuthorizationTaskExecutorMultipleNodesIT
Mar 12, 2026
Merged

Remove AuthorizationTaskExecutorMultipleNodesIT#144042
dimitris-athanasiou merged 2 commits intoelastic:mainfrom
dimitris-athanasiou:remove-AuthorizationTaskExecutorMultipleNodesIT

Conversation

@dimitris-athanasiou
Copy link
Copy Markdown
Contributor

This test is really only testing the task framework itself. There is also a race condition that is causing sporadic failures. As the test does not really offer much, this commit removes it completely.

Closes #137911

This test is really only testing the task framework itself.
There is also a race condition that is causing sporadic failures.
As the test does not really offer much, this commit removes it completely.

Closes elastic#137911
@dimitris-athanasiou dimitris-athanasiou added >test Issues or PRs that are addressing/adding tests auto-backport Automatically create backport pull requests when merged :SearchOrg/Inference Label for the Search Inference team v9.4.0 v9.3.3 labels Mar 11, 2026
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/search-inference-team (Team:Search - Inference)

Copy link
Copy Markdown
Contributor

@jonathan-buttner jonathan-buttner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 11, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: aa56123f-d431-4e3e-ab56-ed503d5a4844

📥 Commits

Reviewing files that changed from the base of the PR and between 51e69a2 and 87a3e91.

📒 Files selected for processing (1)
  • muted-tests.yml
💤 Files with no reviewable changes (1)
  • muted-tests.yml

📝 Walkthrough

Walkthrough

Removed a muted test entry from muted-tests.yml and deleted the integration test class AuthorizationTaskExecutorMultipleNodesIT. The specific test testAuthorizationTaskGetsRelocatedToAnotherNode_WhenTheNodeThatIsRunningItShutsDown was removed along with the test file containing multi-node inference authorization and relocation tests.

🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Linked Issues check ✅ Passed The PR directly addresses issue #137911 by removing the flaky test AuthorizationTaskExecutorMultipleNodesIT that exhibited a 60% failure rate with race conditions.
Out of Scope Changes check ✅ Passed All changes are in-scope: removal of the muted test from muted-tests.yml and deletion of the problematic test file, both directly addressing issue #137911.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • 🛠️ Update Documentation: Commit on current branch
  • 🛠️ Update Documentation: Create PR

Comment @coderabbitai help to get the list of available commands and usage tips.

@dimitris-athanasiou dimitris-athanasiou merged commit ed24cd3 into elastic:main Mar 12, 2026
36 checks passed
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

💔 Backport failed

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 144042

jfreden pushed a commit to jfreden/elasticsearch that referenced this pull request Mar 12, 2026
This test is really only testing the task framework itself.
There is also a race condition that is causing sporadic failures.
As the test does not really offer much, this commit removes it completely.

Closes elastic#137911
@dimitris-athanasiou
Copy link
Copy Markdown
Contributor Author

💚 All backports created successfully

Status Branch Result
9.3

Questions ?

Please refer to the Backport tool documentation

dimitris-athanasiou added a commit to dimitris-athanasiou/elasticsearch that referenced this pull request Mar 12, 2026
This test is really only testing the task framework itself.
There is also a race condition that is causing sporadic failures.
As the test does not really offer much, this commit removes it completely.

Closes elastic#137911

(cherry picked from commit ed24cd3)
dimitris-athanasiou added a commit that referenced this pull request Mar 12, 2026
)

This test is really only testing the task framework itself.
There is also a race condition that is causing sporadic failures.
As the test does not really offer much, this commit removes it completely.

Closes #137911

(cherry picked from commit ed24cd3)
michalborek pushed a commit to michalborek/elasticsearch that referenced this pull request Mar 23, 2026
This test is really only testing the task framework itself.
There is also a race condition that is causing sporadic failures.
As the test does not really offer much, this commit removes it completely.

Closes elastic#137911
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Automatically create backport pull requests when merged backport pending :SearchOrg/Inference Label for the Search Inference team Team:Search - Inference >test Issues or PRs that are addressing/adding tests v9.3.3 v9.4.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI] AuthorizationTaskExecutorMultipleNodesIT testAuthorizationTaskGetsRelocatedToAnotherNode_WhenTheNodeThatIsRunningItShutsDown failing

3 participants