Enable synthetic_id by default under feature flag by burqen · Pull Request #144026 · elastic/elasticsearch

burqen · 2026-03-11T14:03:42Z

Newly created time_series indices use synthetic id by default.

The new IndexVersion, TIME_SERIES_USE_SYNTHETIC_ID_DEFAULT, prevent old indices (with older index version) from changing default behavior.

index.mapping.synthetic_id defaults to true if

Feature flag TSDB_SYNTHETIC_ID_FEATURE_FLAG is enabled
index mode is time_series
index version is TIME_SERIES_USE_SYNTHETIC_ID_DEFAULT or later
codec is default or unset

The synthetic id setting is still allowed to be explicitly set if index version is TIME_SERIES_USE_SYNTHETIC_ID_94 or later. The new index version, TIME_SERIES_USE_SYNTHETIC_ID_DEFAULT, only controls the default behavior.

This logic for if synthetic id should be used or not is duplicated from IndexSettings to IndexMetadata to make sure metadata always agree with settings.

IndexSettings.MODE is moved above SYNTHETIC_ID to allow access.

Relates ES-14156

Newly created time_series indices use synthetic id by default. The new IndexVersion, TIME_SERIES_USE_SYNTHETIC_ID_DEFAULT, prevent old indices (with older index version) from changing default behavior. `index.mapping.synthetic_id` defaults to true if - Feature flag TSDB_SYNTHETIC_ID_FEATURE_FLAG is enabled - index mode is time_series - index version is TIME_SERIES_USE_SYNTHETIC_ID_DEFAULT or later - codec is default or unset and setting is still allowed to be explicitly set if index version is TIME_SERIES_USE_SYNTHETIC_ID_94 or later. Only the default behavior is controlled by TIME_SERIES_USE_SYNTHETIC_ID_DEFAULT. This default logic is duplicated by IndexMetadata to make sure metadata always agree with Settings. MODE setting moved above SYNTHETIC_ID to allow access.

elasticsearchmachine · 2026-03-11T14:04:09Z

Pinging @elastic/es-storage-engine (Team:StorageEngine)

burqen · 2026-03-11T14:04:38Z

server/src/main/java/org/elasticsearch/index/IndexSettings.java

+    /**
+    * The {@link IndexMode "mode"} of the index.
+    */
+    public static final Setting<IndexMode> MODE = Setting.enumSetting(


Needed to move this to have access in SYNTHETIC_ID, but the code is unchanged

fcofdez

Looks good! I think that you're right regarding the node feature, but maybe for safety we might want to bump that too?

...a-streams/src/internalClusterTest/java/org/elasticsearch/datastreams/TSDBSyntheticIdsIT.java

server/src/main/java/org/elasticsearch/index/IndexSettings.java

…etic-id-enable-by-default-behind-ff

burqen · 2026-03-12T07:18:20Z

Looks good! I think that you're right regarding the node feature, but maybe for safety we might want to bump that too?

Yeah, it will be difficult to introduce it retrospectively. We can't remove the existing one (it will prevent clusters from forming), but I'll add a new one in this PR.

…etic-id-enable-by-default-behind-ff

Making sure to add this node feature in the same PR as adding the new index version, `TIME_SERIES_USE_SYNTHETIC_ID_DEFAULT` to make sure the node feature can be used as a shortcut / replacement for checking version in tests.

The compat tests run with a copy of the yaml file from the BWC branch, which doesn't contain the skip for index.time_series_synthetic_id. This means the hardcoded ids in the test doesn't match with actual default behavior anymore, so we skip those tests in the compatibility run. This is safe because the behavior is not changed for existing indices that don't use synthetic id. Only new indices will have the changed behavior, so there is no compatibility issue. To make this work we nedd to make it possible to skip compatibility tests with overloaded names. If the name of the test is also a name of an operation such as `get` or `delete` in below examples, then the build would fail with ``` Execution failed for task ':rest-api-spec:yamlRestCompatTestTransform'. > class com.fasterxml.jackson.databind.node.ObjectNode cannot be cast to class com.fasterxml.jackson.databind.node.ArrayNode ``` Instead of throwing an (assert) exception if the node to transform (skip) is of the wrong type, we now just ignore it instead. Example of test that could not be skipped before, but that can be skipped now: ``` get: - do: get: index: id_generation_test id: cZZNs7B9sSWsyrL5AAABeRnSA5M ``` Written together with Cursor

This is an attempt at avoiding this failure: ``` TSDBSyntheticIdsIT > testDefaultSetting FAILED java.lang.AssertionError: searcher was not warmed up yet for source[assert_no_id_stored_field] ``` If replica hasn't caught up to primary before calling flushAndRefresh the replica would not be refreshed and isWarmedUp would not be set in InternalEngine.ExternalReaderManager.refreshIfNeeded. By calling ensureGreen we make sure that replicate has caught up and that searcher will be warmed up.

fcofdez · 2026-03-12T17:20:38Z

@elasticmachine update branch

…-behind-ff

burqen · 2026-03-13T06:48:07Z

Another green run ✅ Triggering a third one

…-behind-ff

fcofdez · 2026-03-13T08:30:42Z

rest-api-spec/build.gradle

    "Malformed values are now stored in binary doc values which sort differently than stored fields"
  )
+  task.skipTest("delete/70_tsdb/basic tsdb delete", "ids have changed after introduction of synthetic id")
+  task.skipTest("tsdb/25_id_generation/routing_path matches object", "ids have changed after introduction of synthetic id")


can't we set the setting to false in this test suite?

This is only for the compatibility tests. They copy the old yaml file from the bwc branch and updating all of those is not worth it IMO.

burqen · 2026-03-13T10:49:59Z

Upgrade test failing to build buildBwcLinuxTar. Unrelated, retriggering the failing upgrade build step.

* What went wrong:
--
Execution failed for task ':distribution:bwc:main:buildBwcLinuxTar'.
> Process './gradlew [-g, /opt/buildkite-agent/.gradle-main, -Dorg.elasticsearch.build.cache.url=https://gradle-enterprise.elastic.co/cache/, -Dscan.tag.NESTED, -Dbuild.snapshot=true, --full-stacktrace, --parallel, -p, distribution/archives/linux-tar, extractedAssemble, --build-cache]' finished with non-zero exit value 1

fcofdez

LGTM 🚀

…-behind-ff

burqen · 2026-03-13T13:44:35Z

Hi @mosche 👋 I see your name in the git blame of org.elasticsearch.gradle.internal.test.rest.transform.skip.Skip. We could use your eyes on 8358b29 that makes task.skipTest a bit more lenient. Feel free to forward this request to someone more fitting if needed. The commit description has, well... a description.

mosche · 2026-03-13T14:48:54Z

@elastic/es-delivery is probably more knowledgable on the these build tools

burqen · 2026-03-13T14:59:12Z

The test failures from the last run doesn't look relevant, but will trigger a new one.

Test / area	Cause
MixedClusterDownsampleRestIT – Downsample index	k8s.pod.multi-counter field null.
ESQL VerifierTests	Parser: “no viable alternative at input 'BY'”; tests expect different exception/behavior.
XPackRestIT – ESQL usage (telemetry) × 2	esql.features length 37 vs expected 35; esql.functions.json_extract present but should be absent.

…-behind-ff

jozala

I've reviewed the change in the Skip.java file and it looks like a good improvement.
I've left one minor comment.

...-internal/src/main/java/org/elasticsearch/gradle/internal/test/rest/transform/skip/Skip.java

…etic-id-enable-by-default-behind-ff

burqen · 2026-03-16T16:02:26Z

Last test failures:

org.elasticsearch.xpack.test.rest.XPackRestIT.test {p0=esql/60_usage/Basic ESQL usage output (telemetry) non-snapshot version} fails with unrelated failure. Fixed here: #144332

org.elasticsearch.xpack.esql.analysis.AnalyzerUnmappedGoldenTests.testSubqueryKeepUnmapped Fixed here: #144334

…etic-id-enable-by-default-behind-ff

…-behind-ff

burqen · 2026-03-17T16:12:45Z

Latest test failures are a lot around ESQL:

:x-pack:plugin:esql:internalClusterTest
org.elasticsearch.xpack.esql.CsvIT
Caused by: java.lang.IllegalStateException: failed to find action [indices:admin/esql/view/put] to execute
org.elasticsearch.xpack.esql.action.EsqlReductionLateMaterializationSingleNodeIT
org.elasticsearch.xpack.esql.action.EsqlReductionLateMaterializationMultiNodeIT
org.elasticsearch.action.ActionRequestValidationException: Validation Failed: 1: [pragma] only allowed in snapshot builds;
org.elasticsearch.xpack.esql.action.CrossClusterViewIT
java.lang.IllegalStateException: failed to find action [indices:admin/esql/view/put] to execute
org.elasticsearch.xpack.esql.action.ResolveIndexActionIT
java.lang.IllegalStateException: failed to find action [indices:admin/esql/view/put] to execute

Trigger another build.

…-behind-ff

…etic-id-enable-by-default-behind-ff

…-behind-ff

…etic-id-enable-by-default-behind-ff

burqen · 2026-03-19T09:48:05Z

Latest test failures

ServerlessClientYamlTestSuiteIT.test {yaml=tsdb/150_runtime_fields/can't shadow metrics}. There is a similar issue on can't shadow dimensions here: https://github.com/elastic/elasticsearch-serverless/issues/5888
MlWithSecurityIT.test {yaml=ml/data_frame_analytics_crud/Test get stats given multiple analytics} fails with NoShardAvailableActionException and has been flaky before [CI] MlWithSecurityIT test {yaml=ml/data_frame_analytics_crud/Test get stats given multiple analytics} failing #123034

As theses two failures are known issues and unrelated to the enabling of synthetic_id.

* Enable synthetic_id by default if settings are valid Newly created time_series indices use synthetic id by default. The new IndexVersion, TIME_SERIES_USE_SYNTHETIC_ID_DEFAULT, prevent old indices (with older index version) from changing default behavior. `index.mapping.synthetic_id` defaults to true if - Feature flag TSDB_SYNTHETIC_ID_FEATURE_FLAG is enabled - index mode is time_series - index version is TIME_SERIES_USE_SYNTHETIC_ID_DEFAULT or later - codec is default or unset and setting is still allowed to be explicitly set if index version is TIME_SERIES_USE_SYNTHETIC_ID_94 or later. Only the default behavior is controlled by TIME_SERIES_USE_SYNTHETIC_ID_DEFAULT. This default logic is duplicated by IndexMetadata to make sure metadata always agree with Settings. MODE setting moved above SYNTHETIC_ID to allow access. * NodeFeature index.time_series_synthetic_id_default Making sure to add this node feature in the same PR as adding the new index version, `TIME_SERIES_USE_SYNTHETIC_ID_DEFAULT` to make sure the node feature can be used as a shortcut / replacement for checking version in tests. * Skip tsdb/25_id... and delete/70_tsdb in yamlRestCompatTest The compat tests run with a copy of the yaml file from the BWC branch, which doesn't contain the skip for index.time_series_synthetic_id. This means the hardcoded ids in the test doesn't match with actual default behavior anymore, so we skip those tests in the compatibility run. This is safe because the behavior is not changed for existing indices that don't use synthetic id. Only new indices will have the changed behavior, so there is no compatibility issue. To make this work we nedd to make it possible to skip compatibility tests with overloaded names. If the name of the test is also a name of an operation such as `get` or `delete` in below examples, then the build would fail with ``` Execution failed for task ':rest-api-spec:yamlRestCompatTestTransform'. > class com.fasterxml.jackson.databind.node.ObjectNode cannot be cast to class com.fasterxml.jackson.databind.node.ArrayNode ``` Instead of throwing an (assert) exception if the node to transform (skip) is of the wrong type, we now just ignore it instead. Example of test that could not be skipped before, but that can be skipped now: ``` get: - do: get: index: id_generation_test id: cZZNs7B9sSWsyrL5AAABeRnSA5M ``` --- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> and Cursor

burqen added >feature :StorageEngine/TSDB You know, for Metrics v9.4.0 labels Mar 11, 2026

burqen requested review from fcofdez and tlrx March 11, 2026 14:03

elasticsearchmachine added the Team:StorageEngine label Mar 11, 2026

burqen commented Mar 11, 2026

View reviewed changes

fcofdez reviewed Mar 11, 2026

View reviewed changes

...a-streams/src/internalClusterTest/java/org/elasticsearch/datastreams/TSDBSyntheticIdsIT.java Outdated Show resolved Hide resolved

server/src/main/java/org/elasticsearch/index/IndexSettings.java Show resolved Hide resolved

burqen mentioned this pull request Mar 11, 2026

Add missing synthetic_id: false in yaml tsdb/26 #144033

Merged

burqen added 3 commits March 11, 2026 16:15

Remove unnecessary time_series_dimension from field

fec3891

Fix test failure in TSDBSyntheticIdsIT

f45455b

Merge remote-tracking branch 'upstream/main' into ap/2026.03.11.synth…

2ad61ba

…etic-id-enable-by-default-behind-ff

burqen added 4 commits March 12, 2026 10:59

Merge remote-tracking branch 'upstream/main' into ap/2026.03.11.synth…

c10e955

…etic-id-enable-by-default-behind-ff

NodeFeature index.time_series_synthetic_id_default

d299af1

Making sure to add this node feature in the same PR as adding the new index version, `TIME_SERIES_USE_SYNTHETIC_ID_DEFAULT` to make sure the node feature can be used as a shortcut / replacement for checking version in tests.

burqen requested a review from a team as a code owner March 12, 2026 13:08

Merge branch 'main' into ap/2026.03.11.synthetic-id-enable-by-default…

2934324

…-behind-ff

Merge branch 'main' into ap/2026.03.11.synthetic-id-enable-by-default…

64b7f9d

…-behind-ff

fcofdez reviewed Mar 13, 2026

View reviewed changes

This was referenced Mar 13, 2026

Synthetic id field for time_series indices (remove feature flag) #144184

Merged

Enable synthetic id feature, remove feature flag #142366

Closed

fcofdez approved these changes Mar 13, 2026

View reviewed changes

fcofdez requested a review from martijnvg March 13, 2026 11:39

fcofdez requested a review from kkrik-es March 13, 2026 11:39

fcofdez added the test-release Trigger CI checks against release build label Mar 13, 2026

Merge branch 'main' into ap/2026.03.11.synthetic-id-enable-by-default…

299b2e9

…-behind-ff

burqen requested a review from mosche March 13, 2026 13:41

burqen added 3 commits March 13, 2026 16:40

Merge branch 'main' into ap/2026.03.11.synthetic-id-enable-by-default…

60a03c7

…-behind-ff

Merge branch 'main' into ap/2026.03.11.synthetic-id-enable-by-default…

4cfaacf

…-behind-ff

Merge branch 'main' into ap/2026.03.11.synthetic-id-enable-by-default…

6ca2f5f

…-behind-ff

jozala approved these changes Mar 16, 2026

View reviewed changes

...-internal/src/main/java/org/elasticsearch/gradle/internal/test/rest/transform/skip/Skip.java Outdated Show resolved Hide resolved

burqen added 2 commits March 16, 2026 16:13

Remove unused logger from Skip.java

9214cb4

Merge remote-tracking branch 'upstream/main' into ap/2026.03.11.synth…

d5c2caf

…etic-id-enable-by-default-behind-ff

burqen and others added 2 commits March 17, 2026 12:54

Merge remote-tracking branch 'upstream/main' into ap/2026.03.11.synth…

d830bb7

…etic-id-enable-by-default-behind-ff

Merge branch 'main' into ap/2026.03.11.synthetic-id-enable-by-default…

3d3c039

…-behind-ff

Merge branch 'main' into ap/2026.03.11.synthetic-id-enable-by-default…

0c5c514

…-behind-ff

burqen removed the test-release Trigger CI checks against release build label Mar 17, 2026

burqen and others added 5 commits March 17, 2026 20:06

Merge branch 'main' into ap/2026.03.11.synthetic-id-enable-by-default…

b2681f7

…-behind-ff

Merge remote-tracking branch 'upstream/main' into ap/2026.03.11.synth…

cc8a4bb

…etic-id-enable-by-default-behind-ff

Merge branch 'main' into ap/2026.03.11.synthetic-id-enable-by-default…

22c2032

…-behind-ff

Merge branch 'main' into ap/2026.03.11.synthetic-id-enable-by-default…

c6a5c82

…-behind-ff

Merge remote-tracking branch 'upstream/main' into ap/2026.03.11.synth…

c2cf400

…etic-id-enable-by-default-behind-ff

burqen merged commit b636be3 into elastic:main Mar 19, 2026
36 checks passed

Conversation

burqen commented Mar 11, 2026

Uh oh!

elasticsearchmachine commented Mar 11, 2026

Uh oh!

burqen Mar 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fcofdez left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

burqen commented Mar 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fcofdez commented Mar 12, 2026

Uh oh!

burqen commented Mar 13, 2026

Uh oh!

fcofdez Mar 13, 2026

Choose a reason for hiding this comment

Uh oh!

burqen Mar 13, 2026

Choose a reason for hiding this comment

Uh oh!

burqen commented Mar 13, 2026

Uh oh!

fcofdez left a comment

Choose a reason for hiding this comment

Uh oh!

burqen commented Mar 13, 2026

Uh oh!

mosche commented Mar 13, 2026

Uh oh!

burqen commented Mar 13, 2026

Uh oh!

jozala left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

burqen commented Mar 16, 2026

Uh oh!

burqen commented Mar 17, 2026

Uh oh!

burqen commented Mar 19, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

burqen Mar 11, 2026 •

edited

Loading

burqen commented Mar 12, 2026 •

edited

Loading