Skip to content

TSDBDocValuesFormatSingleNodeTests with and without synthetic id #144002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
burqen merged 2 commits into from
Mar 11, 2026
Merged

TSDBDocValuesFormatSingleNodeTests with and without synthetic id #144002

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7bb3ea1
TSDBDocValuesFormatSingleNodeTests with and without synthetic id
burqen Mar 11, 2026
ef8a387
Merge branch 'main' into ap/2026.03.11.synthetic-id-fix-TSDBDocValues…
burqen Mar 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions ...est/java/org/elasticsearch/index/codec/tsdb/es819/TSDBDocValuesFormatSingleNodeTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
package org.elasticsearch.index.codec.tsdb.es819;

import org.apache.lucene.codecs.DocValuesFormat;
import org.apache.lucene.codecs.perfield.PerFieldDocValuesFormat;
import org.apache.lucene.index.DocValuesType;
import org.apache.lucene.index.FieldInfo;
import org.elasticsearch.action.admin.indices.flush.FlushRequest;
Expand All @@ -19,6 +20,7 @@
import org.elasticsearch.index.codec.CodecService;
import org.elasticsearch.index.codec.Elasticsearch93Lucene104Codec;
import org.elasticsearch.index.codec.LegacyPerFieldMapperCodec;
import org.elasticsearch.index.codec.tsdb.ES93TSDBDefaultCompressionLucene103Codec;
import org.elasticsearch.index.engine.Engine;
import org.elasticsearch.indices.IndicesService;
import org.elasticsearch.test.ESSingleNodeTestCase;
Expand All @@ -30,18 +32,22 @@
import static org.elasticsearch.index.IndexSettings.ALLOW_LARGE_BINARY_BLOCK_SIZE;
import static org.hamcrest.Matchers.equalTo;
import static org.hamcrest.Matchers.greaterThan;
import static org.hamcrest.Matchers.instanceOf;
import static org.hamcrest.Matchers.sameInstance;

public class TSDBDocValuesFormatSingleNodeTests extends ESSingleNodeTestCase {

public void testTSDBIndexUsesCorrectDocValuesFormat() throws Exception {
String indexName = "tsdb-test";
Settings settings = Settings.builder()
Settings.Builder settingsBuilder = Settings.builder()
.put(IndexSettings.MODE.getKey(), "time_series")
.put(IndexMetadata.INDEX_ROUTING_PATH.getKey(), "hostname")
.put(IndexSettings.TIME_SERIES_START_TIME.getKey(), "2024-01-01T00:00:00Z")
.put(IndexSettings.TIME_SERIES_END_TIME.getKey(), "2025-01-01T00:00:00Z")
.build();
.put(IndexSettings.TIME_SERIES_END_TIME.getKey(), "2025-01-01T00:00:00Z");
if (IndexSettings.TSDB_SYNTHETIC_ID_FEATURE_FLAG) {
settingsBuilder.put(IndexSettings.SYNTHETIC_ID.getKey(), randomBoolean());
}
Settings settings = settingsBuilder.build();

createIndex(
indexName,
Expand Down Expand Up @@ -113,6 +119,10 @@ private void assertDocValuesFormat(String indexName, DocValuesFormat expectedFor
} else if (codec instanceof CodecService.DeduplicateFieldInfosCodec deduplicateFieldInfosCodec) {
if (deduplicateFieldInfosCodec.delegate() instanceof LegacyPerFieldMapperCodec legacyPerFieldMapperCodec) {
docValuesFormatProvider = legacyPerFieldMapperCodec::getDocValuesFormatForField;
} else if (deduplicateFieldInfosCodec.delegate() instanceof ES93TSDBDefaultCompressionLucene103Codec es93TSDB103Codec) {
assertThat(es93TSDB103Codec.docValuesFormat(), instanceOf(PerFieldDocValuesFormat.class));
docValuesFormatProvider = (field) -> ((PerFieldDocValuesFormat) es93TSDB103Codec.docValuesFormat())
.getDocValuesFormatForField(field);
} else {
fail("Unexpected codec type: " + codec.getClass().getName());
return;
Expand Down
Loading