Skip to content

Fix HistogramUnionState.equals for empty instances #143990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JonasKunz merged 1 commit into from
Mar 11, 2026
Merged

Fix HistogramUnionState.equals for empty instances #143990

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion server/src/main/java/org/elasticsearch/search/aggregations/metrics/HistogramUnionState.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -409,7 +409,7 @@ public void close() {
@Override
public boolean equals(Object o) {
if (this == o) return true;
if (o == null || getClass() != o.getClass()) return false;
if (o instanceof HistogramUnionState == false) return false;

HistogramUnionState that = (HistogramUnionState) o;

Expand Down
11 changes: 11 additions & 0 deletions ...src/test/java/org/elasticsearch/search/aggregations/metrics/HistogramUnionStateTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,6 +185,17 @@ public void testWriteToReadRoundTripPreservesBehavior() throws IOException {
}
}

public void testEmptySingletonWriteToReadRoundTripEquals() throws IOException {
BytesStreamOutput out = new BytesStreamOutput();
HistogramUnionState.EMPTY.writeTo(out);

try (HistogramUnionState roundTripped = HistogramUnionState.read(breaker(), out.bytes().streamInput())) {
assertThat(roundTripped, equalTo(HistogramUnionState.EMPTY));
assertThat(HistogramUnionState.EMPTY, equalTo(roundTripped));
assertThat(roundTripped.hashCode(), equalTo(HistogramUnionState.EMPTY.hashCode()));
}
}

public void testPureTDigestSerializationCompatibility() throws IOException {
try (RandomState state = randomState(false)) {

Expand Down
Loading