Skip to content

Disable synthetic _id in SourceFieldMapper tests#143943

Merged
fcofdez merged 1 commit intoelastic:mainfrom
fcofdez:fix/source-field-mapper-tests-synthetic-id
Mar 10, 2026
Merged

Disable synthetic _id in SourceFieldMapper tests#143943
fcofdez merged 1 commit intoelastic:mainfrom
fcofdez:fix/source-field-mapper-tests-synthetic-id

Conversation

@fcofdez
Copy link
Copy Markdown
Contributor

@fcofdez fcofdez commented Mar 10, 2026

When the TSDB synthetic ID feature flag is enabled,
disable synthetic _id in recovery source tests since the
hardcoded "123" id is not synthetic-id-conformant and
synthetic ids are not relevant to these tests.

Relates #142366

When the TSDB synthetic ID feature flag is enabled, disable
synthetic _id in recovery source tests since the hardcoded
"123" id is not synthetic-id-conformant and synthetic ids are
not relevant to these tests.

Relates elastic#142366
@fcofdez fcofdez requested a review from burqen March 10, 2026 13:07
@fcofdez fcofdez added >test Issues or PRs that are addressing/adding tests Team:StorageEngine :StorageEngine/Mapping The storage related side of mappings v9.4.0 labels Mar 10, 2026
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-storage-engine (Team:StorageEngine)

@fcofdez fcofdez requested a review from tlrx March 10, 2026 13:19
Copy link
Copy Markdown
Member

@tlrx tlrx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fcofdez fcofdez merged commit 7743109 into elastic:main Mar 10, 2026
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:StorageEngine/Mapping The storage related side of mappings Team:StorageEngine >test Issues or PRs that are addressing/adding tests v9.4.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants