Skip to content

Fix flaky MMR diversification YAML tests #143706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mayya-sharipova merged 2 commits into from
Mar 6, 2026
Merged

Fix flaky MMR diversification YAML tests #143706

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c726477
Fix flaky MMR diversification YAML tests
mayya-sharipova Mar 5, 2026
d9d5417
Merge branch 'main' into fix-mrr-test
ioanatia Mar 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions muted-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -366,15 +366,9 @@ tests:
- class: org.elasticsearch.xpack.esql.qa.mixed.EsqlClientYamlIT
method: test {p0=esql/40_tsdb/TS Command grouping on text field}
issue: https://github.com/elastic/elasticsearch/issues/142544
- class: org.elasticsearch.multiproject.test.CoreWithMultipleProjectsClientYamlTestSuiteIT
method: test {yaml=search.retrievers/result-diversification/10_mmr_result_diversification_retriever/Test MMR result diversification single index float type}
issue: https://github.com/elastic/elasticsearch/issues/143430
- class: org.elasticsearch.repositories.azure.AzureBlobContainerRetriesTests
method: testWriteLargeBlob
issue: https://github.com/elastic/elasticsearch/issues/143551
- class: org.elasticsearch.multiproject.test.CoreWithMultipleProjectsClientYamlTestSuiteIT
method: test {yaml=search.retrievers/result-diversification/10_mmr_result_diversification_retriever/Test MMR result diversification multiple indexes}
issue: https://github.com/elastic/elasticsearch/issues/143609
- class: org.elasticsearch.index.query.PrefixQueryBuilderTests
method: testPrefixCircuitBreakerTripsWithLowLimit
issue: https://github.com/elastic/elasticsearch/issues/143548
Expand Down
16 changes: 11 additions & 5 deletions ...test/search.retrievers/result-diversification/10_mmr_result_diversification_retriever.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@ setup:
textvector:
type: dense_vector
dims: 4
index_options:
type: hnsw
id:
type: integer

Expand All @@ -41,6 +43,8 @@ setup:
textvector:
type: dense_vector
dims: 4
index_options:
type: hnsw
id:
type: integer

Expand Down Expand Up @@ -76,6 +80,8 @@ setup:
textvector:
type: dense_vector
dims: 4
index_options:
type: hnsw
rankfield:
type: integer
id:
Expand Down Expand Up @@ -215,7 +221,7 @@ teardown:
- match: { hits.hits.6._source.textbody: "ninth text" }
- match: { hits.hits.7._source.textbody: "seventh text" }
- match: { hits.hits.8._source.textbody: "eighth text" }
- match: { hits.hits.9._source.textbody: "fourth text" }
- match: { hits.hits.9._source.textbody: "fifth text" }

- do:
search:
Expand Down Expand Up @@ -308,7 +314,7 @@ teardown:
- match: { hits.hits.6._source.textbody: "ninth text" }
- match: { hits.hits.7._source.textbody: "seventh text" }
- match: { hits.hits.8._source.textbody: "eighth text" }
- match: { hits.hits.9._source.textbody: "fourth text" }
- match: { hits.hits.9._source.textbody: "fifth text" }

- do:
search:
Expand Down Expand Up @@ -356,7 +362,7 @@ teardown:
- length: { hits.hits: 3 }
- match: { hits.hits.0._source.textbody: "seventh text" }
- match: { hits.hits.1._source.textbody: "eighth text" }
- match: { hits.hits.2._source.textbody: "fourth text" }
- match: { hits.hits.2._source.textbody: "fifth text" }

---
"Test MMR result diversification byte vector type":
Expand Down Expand Up @@ -459,7 +465,7 @@ teardown:
- match: { hits.hits.6._source.textbody: "ninth text" }
- match: { hits.hits.7._source.textbody: "third text other" }
- match: { hits.hits.8._source.textbody: "third text duplicate other" }
- match: { hits.hits.9._source.textbody: "fifth text other" }
- match: { hits.hits.9._source.textbody: "sixth text other" }

- do:
search:
Expand Down Expand Up @@ -514,7 +520,7 @@ teardown:
- match: { hits.hits.6._source.textbody: "ninth text" }
- match: { hits.hits.7._source.textbody: "seventh text" }
- match: { hits.hits.8._source.textbody: "eighth text" }
- match: { hits.hits.9._source.textbody: "fourth text" }
- match: { hits.hits.9._source.textbody: "fifth text" }

---
"Test MMR result diversification rank_window_size restricts top docs":
Expand Down