[Inference API] Handle empty date strings when parsing endpoint metadata#143584
Merged
dimitris-athanasiou merged 2 commits intoelastic:mainfrom Mar 4, 2026
Conversation
…ata heuristics This adds handling of blank date strings when parsing endpoint metadata heuristics by treating it as `null`. This could not occur in practice as EIS won't be serving empty strings. However, there are tests that pass in an empty string (e.g. callers of `createAuthorizedEndpoint` in `ElasticInferenceServiceAuthorizationResponseEntityTests` may lead to this case). Rather than change the tests, it makes more sense to make date parsing more robust.
dimitris-athanasiou
added
>test
Collaborator
|
Pinging @elastic/search-inference-team (Team:Search - Inference) |
jonathan-buttner
approved these changes
Mar 4, 2026
Contributor
jonathan-buttner
left a comment
jonathan-buttner
left a comment
There was a problem hiding this comment.
You might need to update the tests that exist to skip the preconfigured endpoints when the date string is "" because they might start failing now.
dimitris-athanasiou
deleted the
handle-empty-date-strings-parsing-endpoint-metadata
branch
burqen
pushed a commit
to burqen/elasticsearch
that referenced
this pull request
Mar 5, 2026
…ata (elastic#143584) This adds handling of blank date strings when parsing endpoint metadata heuristics by treating it as `null`. This could not occur in practice as EIS won't be serving empty strings. However, there are tests that pass in an empty string (e.g. callers of `createAuthorizedEndpoint` in `ElasticInferenceServiceAuthorizationResponseEntityTests` may lead to this case). Rather than change the tests, it makes more sense to make date parsing more robust.
jfreden
pushed a commit
to jfreden/elasticsearch
that referenced
this pull request
Mar 5, 2026
…ata (elastic#143584) This adds handling of blank date strings when parsing endpoint metadata heuristics by treating it as `null`. This could not occur in practice as EIS won't be serving empty strings. However, there are tests that pass in an empty string (e.g. callers of `createAuthorizedEndpoint` in `ElasticInferenceServiceAuthorizationResponseEntityTests` may lead to this case). Rather than change the tests, it makes more sense to make date parsing more robust.
spinscale
pushed a commit
to spinscale/elasticsearch
that referenced
this pull request
Mar 6, 2026
…ata (elastic#143584) This adds handling of blank date strings when parsing endpoint metadata heuristics by treating it as `null`. This could not occur in practice as EIS won't be serving empty strings. However, there are tests that pass in an empty string (e.g. callers of `createAuthorizedEndpoint` in `ElasticInferenceServiceAuthorizationResponseEntityTests` may lead to this case). Rather than change the tests, it makes more sense to make date parsing more robust.
This was referenced Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds handling of blank date strings when parsing endpoint metadata heuristics by treating it as
null.This could not occur in practice as EIS won't be serving empty strings. However, there are tests that pass in an empty string (e.g. callers of
createAuthorizedEndpointinElasticInferenceServiceAuthorizationResponseEntityTestsmay lead to this case).Rather than change the tests, it makes more sense to make date parsing more robust.