Closed
Conversation
Changes the Reindexer to use a cluster feature check to guard the PIT changes, rather than a feature flag. This will be safer when rolling out the reindexing changes during a rolling upgrade, so that one node does not begin a reindex using PIT before the other nodes are capable of running the corresponding PIT searches.
Extends ReindexFromRemoteWithAuthTests to be parameterised to run both with scroll, and with point-in-time searching enabled. Relates: elastic/elasticsearch-team#2088
joshua-adams-1
added
>test
Contributor
Author
|
I don't think this is needed. Running tests locally defaults to the feature flag being true, which leaves the feature flag = false branches as untested. However, I can add |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#142494 introduced reindexing logic to determine the remote version before opening a PIT. However, since the tests default
NodeFeaturesto false, there was no test coverage of this new code branch. This change modifies a number of unit and integration tests to run against the PIT code, to provide coverage. Note that this only adds coverage for logic added in #142494. All subsequent changes shall add coverage from unit / integration tests as and when needed.Relates: https://github.com/elastic/elasticsearch-team/issues/2088