Skip to content

ES|QL: Fix MMROperatorTests #143453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ioanatia merged 1 commit into from
Mar 3, 2026
Merged

ES|QL: Fix MMROperatorTests #143453

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions muted-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,15 +315,9 @@ tests:
- class: org.elasticsearch.compute.lucene.read.ValuesSourceReaderOperatorTests
method: testWithNulls
issue: https://github.com/elastic/elasticsearch/issues/142434
- class: org.elasticsearch.compute.operator.MMROperatorTests
method: testSimpleLargeInput
issue: https://github.com/elastic/elasticsearch/issues/142437
- class: org.elasticsearch.xpack.esql.common.spatial.H3SphericalGeometryTests
method: testIndexPoints
issue: https://github.com/elastic/elasticsearch/issues/142439
- class: org.elasticsearch.compute.operator.MMROperatorTests
method: testSimpleSmallInput
issue: https://github.com/elastic/elasticsearch/issues/142436
- class: org.elasticsearch.xpack.esql.core.util.RemoteClusterUtilsTests
method: testQualifyAndJoinIndices
issue: https://github.com/elastic/elasticsearch/issues/142442
Expand Down
11 changes: 2 additions & 9 deletions ...lugin/esql/compute/src/test/java/org/elasticsearch/compute/operator/MMROperatorTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,6 @@
import static org.hamcrest.Matchers.equalTo;

public class MMROperatorTests extends OperatorTestCase {

public static double NULL_BLOCK_CHANCE = 0.05;

static List<float[]> TEST_VECTORS = List.of(
new float[] { 0.4f, 0.2f, 0.4f, 0.4f },
new float[] { 0.4f, 0.2f, 0.3f, 0.3f },
Expand Down Expand Up @@ -53,13 +50,9 @@ protected int remaining() {
@Override
protected Page createPage(int positionOffset, int length) {
length = Integer.min(length, remaining());
currentPosition += length;
var blocks = new Block[1];

if (randomDouble() < NULL_BLOCK_CHANCE) {
blocks[0] = blockFactory.newConstantNullBlock(length);
return new Page(blocks);
}

float[] vectors = new float[length * 4];
int[] vectorPositions = new int[length + 1];
int vectorIndex = 0;
Expand All @@ -77,7 +70,7 @@ protected Page createPage(int positionOffset, int length) {
blocks[0] = blockFactory.newFloatArrayBlock(vectors, length, vectorPositions, new BitSet(), Block.MvOrdering.UNORDERED);
} catch (Exception e) {
throw new RuntimeException(e);
} finally {}
}

finish();
return new Page(blocks);
Expand Down