Ensure supported locale outside of Entitlements check#143405
Merged
mamazzol merged 4 commits intoelastic:mainfrom Mar 3, 2026
Merged
Ensure supported locale outside of Entitlements check#143405mamazzol merged 4 commits intoelastic:mainfrom
mamazzol merged 4 commits intoelastic:mainfrom
Conversation
mamazzol
added
>test
elasticsearchmachine
added
v9.4.0
needs:triage
elasticsearchmachine
added
v9.3.2
v8.19.13
v9.2.7
and removed
branch:9.2
branch:8.19
branch:9.3
labels
mamazzol
added
Team:Core/Infra
elasticsearchmachine
removed
the
needs:triage
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
mark-vieira
reviewed
Mar 2, 2026
Contributor
mark-vieira
left a comment
mark-vieira
left a comment
There was a problem hiding this comment.
Seems fine to me. Are we certain that the TestEntitlementRule will always run after whatever sets the random locale?
Contributor
Author
|
ESTestCase has ensureSupportedLocale as |
mamazzol
changed the title
Contributor
Right, my point being that the randomly chosen locale needs to have already been set. I'm not even certain where that happens. |
Contributor
Author
My understanding is that it's randomly set by LuceneTestCase which is the parent class of ESTestCase. The order should be guaranteed by the hierarchy. |
mark-vieira
approved these changes
Mar 2, 2026
mamazzol
added a commit
to mamazzol/elasticsearch
that referenced
this pull request
Mar 3, 2026
* Ensure supported locale in test around entitlements
mamazzol
added a commit
to mamazzol/elasticsearch
that referenced
this pull request
Mar 3, 2026
* Ensure supported locale in test around entitlements
Collaborator
mamazzol
added a commit
to mamazzol/elasticsearch
that referenced
this pull request
Mar 3, 2026
* Ensure supported locale in test around entitlements
szybia
added a commit
to szybia/elasticsearch
that referenced
this pull request
Mar 3, 2026
…cations * upstream/main: (56 commits) Mute org.elasticsearch.compute.lucene.read.ValueSourceReaderTypeConversionTests testLoadAll elastic#143471 [DOCS] Fix ES|QL function and commands lists versioning metadata (elastic#143402) Fix MMROperatorTests (elastic#143453) Fix CSV-escaped quotes in generated docs examples (elastic#143449) Fix SQL client parsing of array header values (elastic#143408) ESQL: Add extended distribution tests and fault injection for external sources (elastic#143420) ESQL: Fix datasource test failures on Windows and FIPS (elastic#143417) Add circuit breaker for query construction to prevent OOM from automaton-based queries (elastic#142150) Cleanup SpecIT logging configuration (elastic#143365) ESQL: Prune unused regex extract nodes in optimizer (elastic#140982) Ensure supported locale outside of Entitlements check (elastic#143405) feat(es|ql): add dense_vector support in coalesce (elastic#142974) [Test] Unmute SnapshotStressTestsIT (elastic#143359) Mute org.elasticsearch.xpack.esql.CsvIT test {csv-spec:lookup-join.LookupJoinWithCoalesceFilterOnRight} elastic#143443 Mute org.elasticsearch.xpack.esql.CsvIT test {csv-spec:lookup-join.MvJoinKeyOnTheLookupIndex} elastic#143442 ESQL: Fix CCS exchange sink cleanup (elastic#143325) Mute org.elasticsearch.xpack.esql.CsvIT test {csv-spec:lookup-join.MvJoinKeyOnTheLookupIndexAfterStats} elastic#143434 Mute org.elasticsearch.xpack.esql.CsvIT test {csv-spec:lookup-join.MvJoinKeyFromRow} elastic#143432 Mute org.elasticsearch.xpack.esql.qa.mixed.MixedClusterEsqlSpecIT test {csv-spec:k8s-timeseries.Datenanos_derivative_compared_to_rate} elastic#143431 Mute org.elasticsearch.multiproject.test.CoreWithMultipleProjectsClientYamlTestSuiteIT test {yaml=search.retrievers/result-diversification/10_mmr_result_diversification_retriever/Test MMR result diversification single index float type} elastic#143430 ...
tballison
pushed a commit
to tballison/elasticsearch
that referenced
this pull request
Mar 3, 2026
* Ensure supported locale in test around entitlements
shmuelhanoch
pushed a commit
to shmuelhanoch/elasticsearch
that referenced
this pull request
Mar 4, 2026
* Ensure supported locale in test around entitlements
This was referenced Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Locale.setDefault(Locale.ENGLISH)can be called from insideESTestCase.ensureSupportedLocale().In tests that:
The code wants to set the locale to English and runs into an entitlement exception
As this is a need for the test, we call
ESTestCase.ensureSupportedLocale()a bit early in the stack when the entitlements for test code are not yet enforced.Closes: #143323