Skip to content

Make large segment vector tests resilient to memory constraints#143366

Merged
ChrisHegarty merged 1 commit intoelastic:mainfrom
ChrisHegarty:fix_>2GB_tests
Mar 2, 2026
Merged

Make large segment vector tests resilient to memory constraints#143366
ChrisHegarty merged 1 commit intoelastic:mainfrom
ChrisHegarty:fix_>2GB_tests

Conversation

@ChrisHegarty
Copy link
Copy Markdown
Contributor

@ChrisHegarty ChrisHegarty commented Mar 2, 2026

The test in JDKVectorLibraryLargeSegmentTests failswith OutOfMemoryError when the maximum memory size is insufficient for the ~2GB Arena.allocate() call. The solution is to wrap the allocation in a tryAllocate helper that catches OutOfMemoryError and skips the test gracefully via assumeTrue instead of failing.

closes: #143356 #143355 #143354 #143353

@ChrisHegarty ChrisHegarty requested a review from ldematte March 2, 2026 08:50
@ChrisHegarty ChrisHegarty added the >test Issues or PRs that are addressing/adding tests label Mar 2, 2026
@ChrisHegarty ChrisHegarty requested a review from a team as a code owner March 2, 2026 08:50
@ChrisHegarty ChrisHegarty added :Search Relevance/Vectors Vector search Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch labels Mar 2, 2026
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-search-relevance (Team:Search Relevance)

Copy link
Copy Markdown
Contributor

@ldematte ldematte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ChrisHegarty ChrisHegarty enabled auto-merge (squash) March 2, 2026 10:08
@ChrisHegarty ChrisHegarty merged commit c9388e5 into elastic:main Mar 2, 2026
35 checks passed
@ChrisHegarty ChrisHegarty deleted the fix_>2GB_tests branch March 2, 2026 11:06
szybia added a commit to szybia/elasticsearch that referenced this pull request Mar 2, 2026
…cations

* upstream/main: (60 commits)
  Use batches for other bulk vector benchmarks (elastic#143167)
  Mute org.elasticsearch.xpack.esql.qa.mixed.MixedClusterEsqlSpecIT test {csv-spec:lookup-join.MvJoinKeyOnTheLookupIndexAfterStats} elastic#143388
  Mute org.elasticsearch.snapshots.ConcurrentSnapshotsIT testBackToBackQueuedDeletes elastic#143387
  [Inference API] Parse endpoint metadata from persisted endpoints (elastic#143081)
  Add cluster formation doc to DistributedArchitectureGuide (elastic#143318)
  Fix flattened root block loader null expectation (elastic#143238)
  Unmute ValueSourceReaderTypeConversionTests testLoadAll (elastic#143189)
  ESQL: Add split coalescing for many small files (elastic#143335)
  Unmute mixed-cluster spatial parse warning test (elastic#143186)
  Fix zero-size estimate in BytesRefBlock null test (elastic#143258)
  Make DataType and DataFormat top-level enums (elastic#143312)
  Add support for steps to change the target index name for later steps (elastic#142955)
  Set mayContainDuplicates flag to test deduplication (elastic#143375)
  ESQL: Fix Driver search load millis as nanos bug (elastic#143267)
  Mute org.elasticsearch.xpack.esql.qa.mixed.MixedClusterEsqlSpecIT test {csv-spec:lookup-join.LookupJoinWithMixPushableAndUnpushableFilters} elastic#143378
  ESQL: Forbid MV_EXPAND before full text functions (elastic#143249)
  ESQL: Fix unresolved name pattern (elastic#143210)
  Implement boxplot queryDSL aggregation for exponential_histograms (elastic#143026)
  Add prefetching to x64 bulk vector implementations (elastic#142387)
  Make large segment vector tests resilient to memory constraints (elastic#143366)
  ...
tballison pushed a commit to tballison/elasticsearch that referenced this pull request Mar 3, 2026
…tic#143366)

The test in JDKVectorLibraryLargeSegmentTests failswith OutOfMemoryError when the maximum memory size is insufficient for the ~2GB Arena.allocate() call. The solution is to wrap the allocation in a tryAllocate helper that catches OutOfMemoryError and skips the test gracefully via assumeTrue instead of failing.

closes: elastic#143356 elastic#143355 elastic#143354 elastic#143353
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Search Relevance/Vectors Vector search Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch >test Issues or PRs that are addressing/adding tests v9.4.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI] JDKVectorLibraryLargeSegmentTests testInt8SquareDistanceBulkWithOffsetsLargeSegment failing

4 participants