Fix search app buffer use-after-free (#143134)#143298
Merged
ebarlas merged 2 commits intoelastic:9.3from Mar 2, 2026
Merged
Conversation
updateSearchApplication released a ReleasableBytesStreamOutput in a try-with-resources block while an async client.index() call still held a BytesReference view of its pages. The bug was latent until elastic#142451 switched the default buffer size to PAGE_SIZE_IN_BYTES, causing BigArrays to recycle pages instead of plain byte arrays. Freed pages were immediately reused, corrupting the IndexRequest source on replica nodes. Bind buffer release to the async listener via ActionListener.run and flush instead of close, matching AsyncTaskIndexService.
elasticsearchmachine
added
needs:triage
ebarlas
added
:Security/Security
DaveCTurner
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a backport of the following commits from
mainto9.3: 755e020