-
Notifications
You must be signed in to change notification settings - Fork 25.8k
Support nested documents in time-series indices with synthetic id #143151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
22b6ad5
add synthetic id fields to nested docs
tlrx 33855bf
add yaml tests
tlrx ca8e278
Update docs/changelog/143151.yaml
tlrx ab23f43
[CI] Auto commit changes from spotless
710b6e8
fix
tlrx 5932729
Merge branch 'main' into 2026/02/26-es-14224
tlrx 08caa8c
Merge branch 'main' into 2026/02/26-es-14224
tlrx e2b72ae
Merge branch 'main' into 2026/02/26-es-14224
tlrx e8f6c49
nested doc fields
tlrx ac274c4
fix assertion
tlrx aa57f91
Merge branch 'main' into 2026/02/26-es-14224
tlrx 0777769
feedback
tlrx cceffbd
Merge branch 'main' into 2026/02/26-es-14224
tlrx 86c8e40
feedback
tlrx e29e37a
docs
tlrx ef9c0c7
Merge branch 'main' into 2026/02/26-es-14224
tlrx 392caaf
Merge branch 'main' into 2026/02/26-es-14224
tlrx File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| area: TSDB | ||
| issues: [] | ||
| pr: 143151 | ||
| summary: Support nested documents in time-series indices with synthetic id | ||
| type: enhancement |
288 changes: 225 additions & 63 deletions
288
...treams/src/internalClusterTest/java/org/elasticsearch/datastreams/TSDBSyntheticIdsIT.java
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
240 changes: 240 additions & 0 deletions
240
...c/yamlRestTest/resources/rest-api-spec/test/tsdb/161_nested_fields_synthetic_id_false.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,240 @@ | ||
| setup: | ||
| - requires: | ||
| cluster_features: ["mapper.tsdb_nested_field_support"] | ||
| reason: "tsdb index with nested field support enabled" | ||
| - requires: | ||
| cluster_features: ["index.time_series_synthetic_id"] | ||
| reason: "index.mapping.synthetic_id requires support for synthetic id in the cluster" | ||
|
|
||
| --- | ||
| "Create TSDB index with field of nested type and synthetic_id false": | ||
| - do: | ||
| indices.create: | ||
| index: test | ||
| body: | ||
| settings: | ||
| index: | ||
| mode: time_series | ||
| number_of_replicas: 1 | ||
| number_of_shards: 1 | ||
| routing_path: [department] | ||
| time_series: | ||
| start_time: 2021-04-28T00:00:00Z | ||
| end_time: 2021-04-29T00:00:00Z | ||
| mapping: | ||
| synthetic_id: false | ||
| mappings: | ||
| properties: | ||
| "@timestamp": | ||
| type: date | ||
| department: | ||
| type: keyword | ||
| time_series_dimension: true | ||
| staff: | ||
| type: integer | ||
| courses: | ||
| type: nested | ||
| properties: | ||
| name: | ||
| type: keyword | ||
| credits: | ||
| type: integer | ||
|
|
||
| - do: | ||
| index: | ||
| index: test | ||
| body: { "@timestamp": "2021-04-28T01:00:00Z", "department": "compsci", "staff": 12, "courses": [ { "name": "Object Oriented Programming", "credits": 3 }, { "name": "Theory of Computation", "credits": 4 } ] } | ||
|
|
||
| - do: | ||
| index: | ||
| index: test | ||
| body: { "@timestamp": "2021-04-28T02:00:00Z", "department": "math", "staff": 20, "courses": [ { "name": "Precalculus", "credits": 1 }, { "name": "Linear Algebra", "credits": 3 } ] } | ||
|
|
||
| - do: | ||
| indices.refresh: | ||
| index: [ test ] | ||
|
|
||
| - do: | ||
| search: | ||
| index: test | ||
| body: | ||
| size: 0 | ||
| query: | ||
| nested: | ||
| path: "courses" | ||
| query: | ||
| bool: | ||
| must: | ||
| - term: | ||
| courses.name: Precalculus | ||
| - term: | ||
| courses.credits: 3 | ||
|
|
||
| - match: { hits.total.value: 0 } | ||
|
|
||
| - do: | ||
| search: | ||
| index: test | ||
| body: | ||
| query: | ||
| nested: | ||
| path: "courses" | ||
| query: | ||
| bool: | ||
| must: | ||
| - term: | ||
| courses.name: "Object Oriented Programming" | ||
| - term: | ||
| courses.credits: 3 | ||
|
|
||
| - match: { hits.total.value: 1 } | ||
| - match: { "hits.hits.0._source.@timestamp": "2021-04-28T01:00:00.000Z" } | ||
| - match: { hits.hits.0._source.department: "compsci" } | ||
| - match: { hits.hits.0._source.courses: [ { "name": "Object Oriented Programming", "credits": 3 }, { "name": "Theory of Computation", "credits": 4, } ] } | ||
|
|
||
| --- | ||
|
|
||
| "TSDB index with multi-level nested fields and synthetic_id false": | ||
| - do: | ||
| indices.create: | ||
| index: test | ||
| body: | ||
| settings: | ||
| index: | ||
| mode: time_series | ||
| number_of_replicas: 1 | ||
| number_of_shards: 1 | ||
| routing_path: [department] | ||
| time_series: | ||
| start_time: 2021-04-28T00:00:00Z | ||
| end_time: 2021-04-29T00:00:00Z | ||
| mapping: | ||
| synthetic_id: false | ||
| mappings: | ||
| properties: | ||
| "@timestamp": | ||
| type: date | ||
| department: | ||
| type: keyword | ||
| time_series_dimension: true | ||
| staff: | ||
| type: integer | ||
| courses: | ||
| type: nested | ||
| properties: | ||
| name: | ||
| type: keyword | ||
| credits: | ||
| type: integer | ||
| students: | ||
| type: nested | ||
| properties: | ||
| name: | ||
| type: text | ||
| major: | ||
| type: keyword | ||
|
|
||
| - do: | ||
| index: | ||
| index: test | ||
| body: | ||
| "@timestamp": "2021-04-28T01:00:00Z" | ||
| department: "compsci" | ||
| staff: 12 | ||
| courses: | ||
| - name: "Object Oriented Programming" | ||
| credits: 3 | ||
| students: | ||
| - name: "Kimora Tanner" | ||
| major: "Computer Science" | ||
| - name: "Bruno Garrett" | ||
| major: "Software Engineering" | ||
| - name: "Theory of Computation" | ||
| credits: 4 | ||
| students: | ||
| - name: "Elliott Booker" | ||
| major: "Computer Engineering" | ||
| - name: "Kimora Tanner" | ||
| major: "Software Engineering" | ||
|
|
||
| - do: | ||
| index: | ||
| index: test | ||
| body: | ||
| "@timestamp": "2021-04-28T02:00:00Z" | ||
| department: "math" | ||
| staff: 20 | ||
| courses: | ||
| - name: "Precalculus" | ||
| credits: 4 | ||
| students: | ||
| - name: "Elliott Ayers" | ||
| major: "Software Engineering" | ||
| - name: "Sylvie Howe" | ||
| major: "Computer Engineering" | ||
| - name: "Linear Algebra" | ||
| credits: 3 | ||
| students: | ||
| - name: "Kimora Tanner" | ||
| major: "Computer Science" | ||
| - name: "Bruno Garett" | ||
| major: "Software Engineering" | ||
| - name: "Amelia Booker" | ||
| major: "Psychology" | ||
|
|
||
| - do: | ||
| index: | ||
| index: test | ||
| body: | ||
| "@timestamp": "2021-04-28T03:00:00Z" | ||
| department: "compsci" | ||
| staff: 12 | ||
| courses: | ||
| - name: "Object Oriented Programming" | ||
| credits: 3 | ||
| students: | ||
| - name: "Kimora Tanner" | ||
| major: "Computer Science" | ||
| - name: "Bruno Garrett" | ||
| major: "Software Engineering" | ||
| - name: "Elliott Booker" | ||
| major: "Computer Engineering" | ||
| - name: "Theory of Computation" | ||
| credits: 4 | ||
| students: | ||
| - name: "Kimora Tanner" | ||
| major: "Software Engineering" | ||
| - name: "Elliott Ayers" | ||
| major: "Software Engineering" | ||
| - name: "Apollo Pittman" | ||
| major: "Computer Engineering" | ||
|
|
||
| - do: | ||
| indices.refresh: | ||
| index: [ test ] | ||
|
|
||
| - do: | ||
| search: | ||
| index: test | ||
| body: | ||
| query: | ||
| nested: | ||
| path: "courses" | ||
| query: | ||
| bool: | ||
| must: | ||
| - nested: | ||
| path: "courses.students" | ||
| query: | ||
| bool: | ||
| must: | ||
| - match: | ||
| courses.students.name: "Elliott" | ||
| - term: | ||
| courses.students.major: "Computer Engineering" | ||
| - term: | ||
| courses.name: "Theory of Computation" | ||
|
|
||
| - match: { hits.total.value: 1 } | ||
| - match: { hits.hits.0._source.department: "compsci" } | ||
| - match: { "hits.hits.0._source.@timestamp": "2021-04-28T01:00:00.000Z" } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would this test suite be executed anytime then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be executed on snapshot builds today, not on release tests. Once we enable the feature by default then we can remove the test suite and only rely on the two other.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The yml tests run in mixed cluster environments and the cluster_feature is only "present" if all members of the cluster has the feature, so this test will run in all cluster combinations pre-9.4.0. So basically
Mixed cluster with old version <9.4.0, run this test.
Mixed cluster with old version >=9.4.0 run the other two.
I think of
cluster_featureas a shortcut to check max sharedIndexVersionacross cluster.