[9.2] fix(esql): check per-shard DateFieldType for DocValuesSkipper (#142752)#142850
Merged
elasticsearchmachine merged 7 commits intoelastic:9.2from Mar 3, 2026
Merged
Conversation
…lastic#142752) hasDocValuesSkipper was derived once from the first shard's DateFieldType and applied globally via doWithContexts. In mixed environments (TSDB shards with DocValuesSkipper + standard shards with PointValues), calling the wrong API on some shards caused sentinel values (Long.MIN_VALUE/Long.MAX_VALUE) to leak into min/max. Replace doWithContexts with direct per-context iteration so each shard's own DateFieldType determines whether to use DocValuesSkipper or PointValues. This also simplifies the early-return guard by removing the incorrect indexed check that could bail out prematurely in mixed modes. (cherry picked from commit 56bfc12)
| Long result = null; | ||
| try { | ||
| for (final SearchExecutionContext context : contexts) { | ||
| if (context.isFieldMapped(field.string()) == false) { |
Contributor
Author
There was a problem hiding this comment.
Note: indexType not available in version 9.2
salvatore-campagna
added
the
auto-merge-without-approval
On 9.2 the setting defaults to false, so the backported test assertion on hasDocValuesSkipper() always failed. Make both values explicit and add a separate test for TSDB without the skipper enabled.
Contributor
Author
|
The |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto9.2:Questions ?
Please refer to the Backport tool documentation