Skip to content

Fix and unmute ReindexResumeIT#142788

Merged
samxbr merged 7 commits intoelastic:mainfrom
samxbr:fix/test
Feb 23, 2026
Merged

Fix and unmute ReindexResumeIT#142788
samxbr merged 7 commits intoelastic:mainfrom
samxbr:fix/test

Conversation

@samxbr
Copy link
Copy Markdown
Contributor

@samxbr samxbr commented Feb 20, 2026

Tests failed due to assumption that each slice will always have enough docs for at least one batch of search request, which may be not be case since slicing on doc Id is random. This updates the assertions to check actual search hits on the first batch.

Ran test suite 100 times to validate: https://gradle-enterprise.elastic.co/s/tmxwczmce5xjq/tests/overview

Closes #142749

@samxbr samxbr added >test Issues or PRs that are addressing/adding tests :Distributed/Reindex Issues relating to reindex that are not caused by issues further down labels Feb 20, 2026
@samxbr samxbr marked this pull request as ready for review February 21, 2026 00:37
@samxbr samxbr requested a review from DaveCTurner February 21, 2026 00:37
@elasticsearchmachine elasticsearchmachine added the Team:Distributed Meta label for distributed team. label Feb 21, 2026
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

Copy link
Copy Markdown
Member

@DaveCTurner DaveCTurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@samxbr samxbr enabled auto-merge (squash) February 23, 2026 16:19
@samxbr samxbr merged commit df9f0d3 into elastic:main Feb 23, 2026
31 of 35 checks passed
szybia added a commit to szybia/elasticsearch that referenced this pull request Feb 23, 2026
…on-sliced-reindex

* upstream/main: (110 commits)
  Add search task watchdog to log hot threads on slow search (elastic#142746)
  Fix return_intermediate_results query param on get async search results (elastic#142875)
  Mute org.elasticsearch.compute.operator.exchange.BatchDriverTests testSinglePageSingleBatch elastic#142895
  Cancel reindex body always has status (elastic#142766)
  Fix built-in roles sync losing updates (elastic#142433)
  ESQL: Clarify docs and add csv test for WHERE in STATS (elastic#133629)
  Fix and unmute ReindexResumeIT (elastic#142788)
  Fix broken release notes
  Mute org.elasticsearch.benchmark.vector.scorer.VectorScorerOSQBenchmarkTests testSingleScalarVsVectorized {p0=384 p1=4 p2=NIO p3=COSINE} elastic#142883
  ES|QL: fix Generative tests for commands that don't change the output schema (elastic#142864)
  Mute org.elasticsearch.benchmark.vector.scorer.VectorScorerOSQBenchmarkTests testSingleScalarVsVectorized {p0=1024 p1=1 p2=NIO p3=DOT_PRODUCT} elastic#142881
  SQL: Fix QlIllegalArgumentException with non-foldable date range queries (elastic#142386)
  Add more errors to the allowed_errors with github issue links (elastic#142862)
  ESQL: reapply "NDJSON datasource" (elastic#142855)
  Add implementation to update service settings method for Alibaba Cloud Search service (elastic#142738)
  Mute org.elasticsearch.snapshots.SnapshotShutdownIT testStartRemoveNodeButDoNotComplete elastic#142871
  Mute org.elasticsearch.snapshots.SnapshotShutdownIT testDeleteSnapshotWithPausedShardSnapshots elastic#142870
  Mute org.elasticsearch.snapshots.SnapshotShutdownIT testAbortSnapshotWhileRemovingNode elastic#142869
  Mute org.elasticsearch.snapshots.SnapshotShutdownIT testRemoveNodeDuringSnapshot elastic#142868
  ES|QL: Guard exponential_histogram TO_STRING against too large inputs (elastic#140718)
  ...
jdconrad pushed a commit to jdconrad/elasticsearch that referenced this pull request Feb 24, 2026
sidosera pushed a commit to sidosera/elasticsearch that referenced this pull request Feb 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Distributed/Reindex Issues relating to reindex that are not caused by issues further down Team:Distributed Meta label for distributed team. >test Issues or PRs that are addressing/adding tests v9.4.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI] ReindexResumeIT testLocalResumeReindexFromScroll_slicedAuto failing

3 participants