Skip to content

Fix IndexSettingsTests synthetic ID tests #142654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
burqen merged 1 commit into from
Feb 24, 2026
Merged

Fix IndexSettingsTests synthetic ID tests #142654

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions muted-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -380,18 +380,6 @@ tests:
- class: org.elasticsearch.xpack.esql.qa.mixed.EsqlClientYamlIT
method: test {p0=esql/40_tsdb/TS Command grouping on text field}
issue: https://github.com/elastic/elasticsearch/issues/142544
- class: org.elasticsearch.index.IndexSettingsTests
method: testSyntheticIdBadVersion
issue: https://github.com/elastic/elasticsearch/issues/142508
- class: org.elasticsearch.index.IndexSettingsTests
method: testSyntheticIdBadCodec
issue: https://github.com/elastic/elasticsearch/issues/142509
- class: org.elasticsearch.index.IndexSettingsTests
method: testSyntheticIdBadMode
issue: https://github.com/elastic/elasticsearch/issues/142510
- class: org.elasticsearch.index.IndexSettingsTests
method: testSyntheticIdCorrectSettings
issue: https://github.com/elastic/elasticsearch/issues/142507
- class: org.elasticsearch.xpack.esql.datasources.GlobDiscoveryLocalTests
method: testRecursiveDoubleStarAllFiles
issue: https://github.com/elastic/elasticsearch/issues/142576
Expand Down
4 changes: 4 additions & 0 deletions server/src/test/java/org/elasticsearch/index/IndexSettingsTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -931,6 +931,7 @@ public void testSame() {
}

public void testSyntheticIdCorrectSettings() {
assumeTrue("Test should only run with feature flag", IndexSettings.TSDB_SYNTHETIC_ID_FEATURE_FLAG);
IndexVersion version = IndexVersionUtils.randomVersionBetween(
IndexVersions.TIME_SERIES_USE_SYNTHETIC_ID_94,
IndexVersion.current()
Expand All @@ -952,6 +953,7 @@ public void testSyntheticIdCorrectSettings() {
}

public void testSyntheticIdBadVersion() {
assumeTrue("Test should only run with feature flag", IndexSettings.TSDB_SYNTHETIC_ID_FEATURE_FLAG);
IndexVersion badVersion = IndexVersionUtils.getPreviousVersion(IndexVersions.TIME_SERIES_USE_SYNTHETIC_ID_94);
IndexMode mode = IndexMode.TIME_SERIES;
String codec = CodecService.DEFAULT_CODEC;
Expand Down Expand Up @@ -980,6 +982,7 @@ public void testSyntheticIdBadVersion() {
}

public void testSyntheticIdBadCodec() {
assumeTrue("Test should only run with feature flag", IndexSettings.TSDB_SYNTHETIC_ID_FEATURE_FLAG);
IndexVersion version = IndexVersionUtils.randomVersionBetween(
IndexVersions.TIME_SERIES_USE_SYNTHETIC_ID_94,
IndexVersion.current()
Expand Down Expand Up @@ -1017,6 +1020,7 @@ public void testSyntheticIdBadCodec() {
}

public void testSyntheticIdBadMode() {
assumeTrue("Test should only run with feature flag", IndexSettings.TSDB_SYNTHETIC_ID_FEATURE_FLAG);
IndexVersion version = IndexVersionUtils.randomVersionBetween(
IndexVersions.TIME_SERIES_USE_SYNTHETIC_ID_94,
IndexVersion.current()
Expand Down