ESQL: remove incorrect inline stats pruning (#141056)#142389
Merged
elasticsearchmachine merged 4 commits intoelastic:9.3from Feb 13, 2026
Merged
ESQL: remove incorrect inline stats pruning (#141056)#142389elasticsearchmachine merged 4 commits intoelastic:9.3from
elasticsearchmachine merged 4 commits intoelastic:9.3from
Conversation
Removes incorrect pruning in `inline stats` that lacked taking into consideration the fact that groupings can be multi-valued. Fixes elastic#139359 (comment) (grouping by an mv fields can lead to inconsistencies in certain queries) Fixes elastic#139359 Fixes elastic#140757 This also extracts a bunch of tests methods from the huge `LogicalPlanOptimizerTests` and moves them to a new test class - `PruneColumnsTests` which should include most of the tests that have in the spotlight the `PruneColumns` optimization rule. (cherry picked from commit 244538b)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports #141056
(cherry picked from commit 244538b)
There are some small differences from the original PR and they are due to these two PRs that are 9.4 only:
#137923
#140238