[ESQL] Log compute engine server failures as ERROR#142330
Merged
MattAlp merged 6 commits intoelastic:mainfrom Feb 12, 2026
Merged
[ESQL] Log compute engine server failures as ERROR#142330MattAlp merged 6 commits intoelastic:mainfrom
MattAlp merged 6 commits intoelastic:mainfrom
Conversation
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
Collaborator
|
Hi @MattAlp, I've created a changelog YAML for you. |
x-pack/plugin/esql/compute/src/main/java/org/elasticsearch/compute/operator/Driver.java
Show resolved
Hide resolved
x-pack/plugin/esql/compute/src/test/java/org/elasticsearch/compute/operator/DriverTests.java
Outdated
Show resolved
Hide resolved
x-pack/plugin/esql/compute/src/test/java/org/elasticsearch/compute/operator/DriverTests.java
Outdated
Show resolved
Hide resolved
alex-spies
approved these changes
Feb 12, 2026
Contributor
alex-spies
left a comment
There was a problem hiding this comment.
Thanks @MattAlp , I think this is the right solution.
Left some suggestions for expanded test coverage. It'd would be nice if you could look into the additional cases, but apart from that this is good to go from my side and doesn't require re-review from me.
x-pack/plugin/esql/compute/src/main/java/org/elasticsearch/compute/operator/Driver.java
Show resolved
Hide resolved
x-pack/plugin/esql/compute/src/test/java/org/elasticsearch/compute/operator/DriverTests.java
Outdated
Show resolved
Hide resolved
x-pack/plugin/esql/compute/src/test/java/org/elasticsearch/compute/operator/DriverTests.java
Outdated
Show resolved
Hide resolved
x-pack/plugin/esql/compute/src/test/java/org/elasticsearch/compute/operator/DriverTests.java
Outdated
Show resolved
Hide resolved
Contributor
|
Oh, and I also locally tried this by reproducing the current bug in |
sidosera
pushed a commit
to sidosera/elasticsearch
that referenced
this pull request
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #139883.
Keep 4xx driver failures at
DEBUG, and log non-4xx runtime driver failures atERROR(wasWARN).Add
DriverTestscoverage to verify server-side failures log atERROR, while 4xx failures do not log atWARN/ERROR.Validated with:
./gradlew :x-pack:plugin:esql:compute:test --tests "org.elasticsearch.compute.operator.DriverTests"(TIL that
gh+ LLMs go well together)