Skip to content

[ESQL] Log compute engine server failures as ERROR#142330

Merged
MattAlp merged 6 commits intoelastic:mainfrom
MattAlp:fix-esql-compute-error-logging-139883
Feb 12, 2026
Merged

[ESQL] Log compute engine server failures as ERROR#142330
MattAlp merged 6 commits intoelastic:mainfrom
MattAlp:fix-esql-compute-error-logging-139883

Conversation

@MattAlp
Copy link
Copy Markdown
Contributor

@MattAlp MattAlp commented Feb 11, 2026

Closes #139883.

Keep 4xx driver failures at DEBUG, and log non-4xx runtime driver failures at ERROR (was WARN).
Add DriverTests coverage to verify server-side failures log at ERROR, while 4xx failures do not log at WARN/ERROR.

Validated with:
./gradlew :x-pack:plugin:esql:compute:test --tests "org.elasticsearch.compute.operator.DriverTests"

(TIL that gh + LLMs go well together)

@elasticsearchmachine elasticsearchmachine added v9.4.0 needs:triage Requires assignment of a team area label labels Feb 11, 2026
@MattAlp MattAlp added >bug Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) :Analytics/Compute Engine Analytics in ES|QL labels Feb 11, 2026
@MattAlp MattAlp requested a review from alex-spies February 11, 2026 17:12
@elasticsearchmachine elasticsearchmachine removed the needs:triage Requires assignment of a team area label label Feb 11, 2026
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

Hi @MattAlp, I've created a changelog YAML for you.

Copy link
Copy Markdown
Contributor

@alex-spies alex-spies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MattAlp , I think this is the right solution.

Left some suggestions for expanded test coverage. It'd would be nice if you could look into the additional cases, but apart from that this is good to go from my side and doesn't require re-review from me.

@alex-spies
Copy link
Copy Markdown
Contributor

Oh, and I also locally tried this by reproducing the current bug in FIRST/LAST, and it logs as expected, even when running async. Great :)

curl -u elastic:password -H "Content-Type: application/json" "127.0.0.1:9200/_query/async" -d '
{ "wait_for_completion_timeout": "1ms",
  "query": "row x = 1::long | stats y = first(x, x)"}'


[2026-02-12T11:07:56,530][ERROR][o.e.c.o.Driver           ] [runTask-0] Error running driver [single] java.lang.ArrayIndexOutOfBoundsException: Index 1 out of bounds for length 1

@MattAlp MattAlp merged commit cfed1ed into elastic:main Feb 12, 2026
31 of 35 checks passed
sidosera pushed a commit to sidosera/elasticsearch that referenced this pull request Feb 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Analytics/Compute Engine Analytics in ES|QL :Analytics/ES|QL AKA ESQL >bug Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v9.4.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ESQL: Ensure ERROR level logs for bugs in the compute engine

4 participants