Revert "Partition time-series source (#140475)"#141229
Merged
dnhatn merged 1 commit intoelastic:mainfrom Jan 24, 2026
Merged
Conversation
This reverts commit 54ee110.
dnhatn
added
:StorageEngine/ES|QL
dnhatn
force-pushed
the
revert-partition
branch
from
71580b0 to
e3f80ae
Compare
Collaborator
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
Member
Author
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
dnhatn
added a commit
to dnhatn/elasticsearch
that referenced
this pull request
Jan 24, 2026
The competitive benchmark shows a significant performance regression from elastic#140475. This is likely due to the high number of CPUs in the benchmark, which results in many small slices and adds significant overhead. It is better to revert this change for now and adjust the partitioning for cases with high CPU and more than one shard before merging again. Relates elastic#14047 (cherry picked from commit 1146b88) # Conflicts: # x-pack/plugin/esql/qa/testFixtures/src/main/resources/k8s-timeseries.csv-spec
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jan 24, 2026
The competitive benchmark shows a significant performance regression from #140475. This is likely due to the high number of CPUs in the benchmark, which results in many small slices and adds significant overhead. It is better to revert this change for now and adjust the partitioning for cases with high CPU and more than one shard before merging again. Relates #14047 (cherry picked from commit 1146b88) # Conflicts: # x-pack/plugin/esql/qa/testFixtures/src/main/resources/k8s-timeseries.csv-spec
Contributor
|
Makes sense, let's iterate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The competitive benchmark shows a significant performance regression from #140475. This is likely due to the high number of CPUs in the benchmark, which results in many small slices and adds significant overhead.
It is better to revert this change for now and adjust the partitioning for cases with high CPU and more than one shard before merging again.
Relates #140475