Delay partial results#141073
Merged
chrisparrinello merged 59 commits intoelastic:mainfrom Feb 17, 2026
Merged
Conversation
chrisparrinello
force-pushed
the
delay_partial_results
branch
from
c60caf6 to
d5aae4d
Compare
elasticsearchmachine
added
the
needs:triage
chrisparrinello
added
>enhancement
Team:Search Foundations
Contributor
Author
|
Based on conversations with @quux00 and @naj-h, we decided to rename We think |
quux00
requested changes
Feb 13, 2026
Contributor
quux00
left a comment
quux00
left a comment
There was a problem hiding this comment.
Minor nit left on code comments and request to remove the changes to SearchResponseMerger (communicated via DM). After that I think I can approve.
| int totalShards = numShards + numSkippedShards; | ||
|
|
||
| // Ensure that given partial results from shard searches, the result we send to the listeners does not contain partial results | ||
| // because partialResultsSupressed is set to true. Passing partialResultsSupressed set to true in the assertCompletionListeners |
Contributor
There was a problem hiding this comment.
nit: "partialResultsSupressed" is misspelled twice here and in the comments below.
chrisparrinello
added a commit
that referenced
this pull request
Feb 23, 2026
…ts (#142875) Change from partial_results to return_intermediate_results #141073 introduced a new query parameter to allow clients to decide whether or not intermediate results should be returned when getting async search results if the query is not complete. The initial Github issue asked for a partial_results query parameter but it was decided to change it to return_intermediate_results. That change was made in the PR in all places except for RestGetAsyncSearchAction. This PR corrects that oversight.
jdconrad
pushed a commit
to jdconrad/elasticsearch
that referenced
this pull request
Feb 24, 2026
…ts (elastic#142875) Change from partial_results to return_intermediate_results elastic#141073 introduced a new query parameter to allow clients to decide whether or not intermediate results should be returned when getting async search results if the query is not complete. The initial Github issue asked for a partial_results query parameter but it was decided to change it to return_intermediate_results. That change was made in the PR in all places except for RestGetAsyncSearchAction. This PR corrects that oversight.
sidosera
pushed a commit
to sidosera/elasticsearch
that referenced
this pull request
Feb 24, 2026
…ts (elastic#142875) Change from partial_results to return_intermediate_results elastic#141073 introduced a new query parameter to allow clients to decide whether or not intermediate results should be returned when getting async search results if the query is not complete. The initial Github issue asked for a partial_results query parameter but it was decided to change it to return_intermediate_results. That change was made in the PR in all places except for RestGetAsyncSearchAction. This PR corrects that oversight.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #139828.
Implements a new query param,
partial_results, on_async_search/{id}to not calculate or return partial results if the query is still running. The query param defaults totrueif not specified in the request. Ifpartial_resultsis true and the search is still running, the search response will include any hits and partial aggregations that are available. Ifpartial_resultsis false and the search is still running, the search response will not include any hits (but possibly include total hits) nor will include any partial aggregations.Once the search is complete, the response will include the final results if successful or the partial results in the case of a failure. This is the same behavior as before the implementation of the
partial_resultsquery param.