Skip to content

Use Double.compare to compare doubles in tdigest.Sort #141049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kkrik-es merged 3 commits into from
Jan 21, 2026
Merged

Use Double.compare to compare doubles in tdigest.Sort #141049

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
00d6e10
Use Double.compare to compare doubles in tdigest.Sort
kkrik-es Jan 21, 2026
637c5ce
Update docs/changelog/141049.yaml
kkrik-es Jan 21, 2026
0dc8c65
[CI] Auto commit changes from spotless
Jan 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions docs/changelog/141049.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
pr: 141049
summary: Use Double.compare to compare doubles in tdigest.Sort
area: Aggregations
type: bug
issues: []
16 changes: 10 additions & 6 deletions libs/tdigest/src/main/java/org/elasticsearch/tdigest/Sort.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,12 +91,15 @@ private static void stableQuickSort(TDigestIntArray order, TDigestDoubleArray va
i++;
}
low++;
} else if (vi > pivotValue || (vi == pivotValue && pi > pv)) {
high--;
swap(order, i, high);
} else {
// vi < pivotValue || (vi == pivotValue && pi < pv)
i++;
int c = Double.compare(vi, pivotValue);
if (c > 0 || (c == 0 && pi > pv)) {
high--;
swap(order, i, high);
} else {
// vi < pivotValue || (vi == pivotValue && pi < pv)
i++;
}
}
}
// invariant: (values[order[k]],order[k]) == (pivotValue, pv) for k in [0..low)
Expand Down Expand Up @@ -169,7 +172,8 @@ private static void stableInsertionSort(TDigestIntArray order, TDigestDoubleArra
// values in [start, i) are ordered
// scan backwards to find where to stick t
for (int j = i; j >= m; j--) {
if (j == 0 || values.get(order.get(j - 1)) < v || (values.get(order.get(j - 1)) == v && (order.get(j - 1) <= vi))) {
int c = (j == 0) ? -1 : Double.compare(values.get(order.get(j - 1)), v);
if (c < 0 || (c == 0 && (order.get(j - 1) <= vi))) {
if (j < i) {
order.set(j + 1, order, j, i - j);
order.set(j, t);
Expand Down