[ESQ|L] Append an implicit limit to subqueries with unbounded sort#141025
Merged
fang-xing-esql merged 6 commits intoelastic:mainfrom Jan 28, 2026
Merged
Conversation
elasticsearchmachine
added
the
Team:Analytics
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
craigtaverner
approved these changes
Jan 26, 2026
Contributor
craigtaverner
left a comment
craigtaverner
left a comment
There was a problem hiding this comment.
LGTM, although I can imagine possibly simpler code.
| return subquery; | ||
| } | ||
|
|
||
| private static LogicalPlan appendLimitIfNeededForOrderBy(LogicalPlan subquery, LogicalOptimizerContext context) { |
Contributor
There was a problem hiding this comment.
I would think that a transformDown would be simpler code than this approach with forEachDownMayReturnEarly, and later planWithLimit.
Member
Author
There was a problem hiding this comment.
forEachDownMayReturnEarly exits early if it finds a limit before finding a sort, I'll add another check, if an unbounded sort is found, it exits early as well.
Member
Author
Thanks for the review @craigtaverner ! I modified the |
fang-xing-esql
deleted the
append-implicit-limit-to-unbounded-sort-in-subquery
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The implicit
limitappended to each subquery is removed by #139058, however there are a couple of cases where we need to append an implicit limit to a subquery, they are described in the above PR.knnhas been supported, and this PR is mainly to support unboundedsortin a subquery by appending an implicitlimit, which is more convenient when the view definition does not have an explicitlimitafter asort.