ESQL: WIP: simplify PruneColumns#140835
Closed
alex-spies wants to merge 2 commits intoelastic:mainfrom
Closed
Conversation
Contributor
Author
|
The reproducers mentioned in #139359 all run. I haven't validated their results, though, but they at least don't explode with "missing attribute" anymore. |
Contributor
Author
|
Closing in favor of #141056 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not merge.
This is an attempt at simplifying PruneColumns by removing some special casing that conceptually doesn't seem to be required, esp. when dealing with InlineStats.
Main changes:
Most optimizer tests still pass and none exhibit the dreaded "optimized incorrectly due to missing attributes". All single node spec tests still pass.
If we go with this, we may need to make PruneColumns version-aware, because past versions probably can't deal with empty Projects.
Relates #139359
Relates #140757