Merged
Conversation
Since 8.2, Transform now calls an action to get the checkpoint info, rather than calculating it all locally. Now that 9.x only supports 8.19.x, this code is no longer in use.
prwhelan
added
>refactoring
:ml/Transform
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes backwards compatibility code from the Transform checkpoint functionality that was needed to support clusters older than version 8.2. Since 9.x only supports 8.19.x and later, this legacy code path is no longer necessary.
Changes:
- Removed BWC checkpoint extraction logic that handled clusters without the GetCheckpointAction API
- Removed test cases covering the legacy checkpoint extraction methods
- Cleaned up unused imports and simplified the checkpoint retrieval flow
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| DefaultCheckpointProvider.java | Removed BWC fallback logic, the extractIndexCheckPoints method, and the getCheckpointsFromOneClusterBWC method; simplified the checkpoint retrieval to only use the GetCheckpointAction API |
| TransformsCheckpointServiceTests.java | Removed test methods for the deprecated extractIndexCheckPoints function |
| DefaultCheckpointProviderTests.java | Removed test case for handling shard failures in the BWC code path and the associated mock helper method |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
|
Pinging @elastic/ml-core (Team:ML) |
prwhelan
added a commit
to prwhelan/elasticsearch
that referenced
this pull request
Apr 3, 2026
In elastic#140617, we had deleted BWC code to check checkpoint info. This test pattern is no longer needed to verify that behavior. Resolve elastic#141112
prwhelan
added a commit
that referenced
this pull request
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since 8.2, Transform now calls an action to get the checkpoint info, rather than calculating it all locally. Now that 9.x only supports 8.19.x, this code is no longer in use.