Skip to content

ESQL: Added more null aggs tests on RATE#140585

Merged
ivancea merged 5 commits intoelastic:mainfrom
ivancea:esql-add-aggs-null-extra-timeseries-tests
Jan 14, 2026
Merged

ESQL: Added more null aggs tests on RATE#140585
ivancea merged 5 commits intoelastic:mainfrom
ivancea:esql-add-aggs-null-extra-timeseries-tests

Conversation

@ivancea
Copy link
Contributor

@ivancea ivancea commented Jan 13, 2026

Continuation of #139797, adding more tests for timeseries

@ivancea ivancea added >test Issues or PRs that are addressing/adding tests Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) test-full-bwc Trigger full BWC version matrix tests test-release Trigger CI checks against release build :Analytics/ES|QL AKA ESQL test-update-serverless v9.3.1 v9.4.0 labels Jan 13, 2026
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

null | "{""cluster"":""qa"",""pod"":""two""}"
;

rateOnNullsWithTimeseriesColumn
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This name is identical with the previous test. Should we also include the fact it's doing a count in its name?

Copy link
Contributor Author

@ivancea ivancea Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohmm... Renamed the last test 😄

Copy link
Contributor

@dimitris-athanasiou dimitris-athanasiou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ivancea ivancea enabled auto-merge (squash) January 14, 2026 11:12
@ivancea ivancea disabled auto-merge January 14, 2026 11:13
@ivancea ivancea enabled auto-merge (squash) January 14, 2026 12:25
@ivancea ivancea removed test-full-bwc Trigger full BWC version matrix tests test-release Trigger CI checks against release build test-update-serverless labels Jan 14, 2026
@ivancea ivancea merged commit 5c046f6 into elastic:main Jan 14, 2026
35 checks passed
@ivancea ivancea deleted the esql-add-aggs-null-extra-timeseries-tests branch January 14, 2026 13:23
ivancea added a commit to ivancea/elasticsearch that referenced this pull request Jan 14, 2026
Continuation of elastic#139797, adding more tests for timeseries
elasticsearchmachine pushed a commit that referenced this pull request Jan 15, 2026
spinscale pushed a commit to spinscale/elasticsearch that referenced this pull request Jan 21, 2026
Continuation of elastic#139797, adding more tests for timeseries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Analytics/ES|QL AKA ESQL Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test Issues or PRs that are addressing/adding tests v9.3.1 v9.4.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants