Skip to content

Disable high cardinality tests on release builds#140503

Merged
elasticsearchmachine merged 4 commits intoelastic:mainfrom
craigtaverner:disable_high_cardinality_tests
Jan 12, 2026
Merged

Disable high cardinality tests on release builds#140503
elasticsearchmachine merged 4 commits intoelastic:mainfrom
craigtaverner:disable_high_cardinality_tests

Conversation

@craigtaverner
Copy link
Contributor

The PR at #139990 introduced a snapshot-only feature, but the tests attempt to run this in release builds. This fix makes sure the new feature is only run in snapshot builds.

Fixes #140498

This is a snapshot-only feature and should only be tested on snapshot builds.
@craigtaverner craigtaverner added >test Issues or PRs that are addressing/adding tests Team:StorageEngine :StorageEngine/ES|QL Timeseries / metrics / PromQL / logsdb capabilities in ES|QL labels Jan 12, 2026
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-storage-engine (Team:StorageEngine)

Copy link
Member

@martijnvg martijnvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, LGTM otherwise.

params.add(new Object[] { new StandardSetup(fieldType, multivaluedField, docValuesMode, allowEmpty, 100) });
}
if (fieldType.equals("keyword")) {
if (fieldType.equals("keyword") && Build.current().isSnapshot()) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe check the EXTENDED_DOC_VALUES_PARAMS_FF feature flag?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@craigtaverner craigtaverner added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Jan 12, 2026
Copy link
Member

@martijnvg martijnvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM2

@elasticsearchmachine elasticsearchmachine merged commit 8e3d3c9 into elastic:main Jan 12, 2026
36 checks passed
@craigtaverner craigtaverner deleted the disable_high_cardinality_tests branch January 12, 2026 14:41
martijnvg added a commit to martijnvg/elasticsearch that referenced this pull request Jan 12, 2026
szybia added a commit to szybia/elasticsearch that referenced this pull request Jan 12, 2026
…i-project-tests

* upstream/main: (23 commits)
  Fix `testAckListenerReceivesNacksIfPublicationTimesOut` (elastic#140514)
  Reduce priority of clear-cache tasks (elastic#139685)
  Add docs and tests about `StreamOutput` to memory (elastic#140365)
  ES|QL - dense_vector support for COUNT, PRESENT, ABSENT aggregator functions (elastic#139914)
  Add release notes for v9.2.4 release (elastic#140487)
  Add release notes for v9.1.10 release (elastic#140488)
  Add conncectors release notes for 9.1.10, 9.2.4 (elastic#140499)
  Add parameter support in PromQL query durations (elastic#139873)
  Improve testing of STS credentials reloading (elastic#140114)
  Fix zstd native binary publishing script to support newer versions (elastic#140485)
  Add FlattenedFieldBinaryVsSortedSetDocValuesSyntheticSourceIT (elastic#140489)
  Store fallback match only text fields in binary doc values (elastic#140189)
  [DiskBBQ] Use the new merge executor for intra-merge parallelism (elastic#139942)
  ESQL: introduce support for mapping-unavailable fields (elastic#140463)
  Add ESNextOSQVectorsScorerTests (elastic#140436)
  Disable high cardinality tests on release builds (elastic#140503)
  ESQL: TRange timezone support (elastic#139911)
  Directly compressing `StreamOutput` (elastic#140502)
  ES|QL - fix dense vector enrich bug (elastic#139774)
  Use CrossProjectModeDecider in RemoteClusterService (elastic#140481)
  ...
spinscale pushed a commit to spinscale/elasticsearch that referenced this pull request Jan 21, 2026
The PR at elastic#139990
introduced a snapshot-only feature, but the tests attempt to run this in
release builds. This fix makes sure the new feature is only run in
snapshot builds.

Fixes elastic#140498
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :StorageEngine/ES|QL Timeseries / metrics / PromQL / logsdb capabilities in ES|QL Team:StorageEngine >test Issues or PRs that are addressing/adding tests v9.4.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ESQL: SingleValueMatchQueryTests failing in release tests

3 participants