Make a few methods static & remove outdated TODO in DataStream #140479
+1
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the most minor of nits. I was walking through this earlier and noticed some methods that could be static to indicate that they're helpers on the class. This commit also removes a TODO about making mode/start/end values on the IndexMetadata instead of settings, which has already happened.
dakrone
added
>non-issue
:Data Management/Data streams
elasticsearchmachine
added
Team:Data Management
Collaborator
|
Pinging @elastic/es-data-management (Team:Data Management) |
dakrone
added
the
auto-merge-without-approval
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the most minor of nits. I was walking through this earlier and noticed some methods that could be static to indicate that they're helpers on the class. This commit also removes a TODO about making mode/start/end values on the IndexMetadata instead of settings, which has already happened.