Skip to content

[9.3] Remove unused method ElasticInferenceService.translateToChunkedResults (#140442) #140455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dimitris-athanasiou merged 1 commit into from
Jan 9, 2026
Merged

[9.3] Remove unused method ElasticInferenceService.translateToChunkedResults (#140442) #140455

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/InferencePlugin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@

package org.elasticsearch.xpack.inference;

import org.apache.logging.log4j.LogManager;
import org.apache.logging.log4j.Logger;
import org.apache.lucene.util.SetOnce;
import org.elasticsearch.action.support.MappedActionFilter;
import org.elasticsearch.client.internal.Client;
Expand Down Expand Up @@ -209,8 +207,6 @@ public class InferencePlugin extends Plugin
ClusterPlugin,
PersistentTaskPlugin {

private static final Logger logger = LogManager.getLogger(InferencePlugin.class);

/**
* When this setting is true the verification check that
* connects to the external service will not be made at
Expand Down
19 changes: 0 additions & 19 deletions ...main/java/org/elasticsearch/xpack/inference/services/elastic/ElasticInferenceService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
import org.elasticsearch.TransportVersion;
import org.elasticsearch.action.ActionListener;
import org.elasticsearch.cluster.service.ClusterService;
import org.elasticsearch.common.Strings;
import org.elasticsearch.common.ValidationException;
import org.elasticsearch.core.Nullable;
import org.elasticsearch.core.TimeValue;
Expand All @@ -34,10 +33,6 @@
import org.elasticsearch.xpack.core.inference.action.InferenceAction;
import org.elasticsearch.xpack.core.inference.chunking.ChunkingSettingsBuilder;
import org.elasticsearch.xpack.core.inference.chunking.EmbeddingRequestChunker;
import org.elasticsearch.xpack.core.inference.results.ChunkedInferenceEmbedding;
import org.elasticsearch.xpack.core.inference.results.ChunkedInferenceError;
import org.elasticsearch.xpack.core.inference.results.SparseEmbeddingResults;
import org.elasticsearch.xpack.core.ml.inference.results.ErrorInferenceResults;
import org.elasticsearch.xpack.inference.external.http.sender.ChatCompletionInput;
import org.elasticsearch.xpack.inference.external.http.sender.EmbeddingsInput;
import org.elasticsearch.xpack.inference.external.http.sender.HttpRequestSender;
Expand All @@ -62,8 +57,6 @@
import java.util.Map;
import java.util.Set;

import static org.elasticsearch.inference.InferenceStringGroup.toInferenceStringList;
import static org.elasticsearch.xpack.core.inference.results.ResultUtils.createInvalidChunkedResultException;
import static org.elasticsearch.xpack.inference.services.ServiceFields.MAX_INPUT_TOKENS;
import static org.elasticsearch.xpack.inference.services.ServiceFields.MODEL_ID;
import static org.elasticsearch.xpack.inference.services.ServiceUtils.createInvalidModelException;
Expand Down Expand Up @@ -515,18 +508,6 @@ public static SimilarityMeasure defaultDenseTextEmbeddingsSimilarity() {
return SimilarityMeasure.COSINE;
}

private static List<ChunkedInference> translateToChunkedResults(InferenceInputs inputs, InferenceServiceResults inferenceResults) {
if (inferenceResults instanceof SparseEmbeddingResults sparseEmbeddingResults) {
var inputsAsList = toInferenceStringList(inputs.castTo(EmbeddingsInput.class).getInputs());
return ChunkedInferenceEmbedding.listOf(inputsAsList, sparseEmbeddingResults);
} else if (inferenceResults instanceof ErrorInferenceResults error) {
return List.of(new ChunkedInferenceError(error.getException()));
} else {
String expectedClass = Strings.format("%s", SparseEmbeddingResults.class.getSimpleName());
throw createInvalidChunkedResultException(expectedClass, inferenceResults.getWriteableName());
}
}

private TraceContext getCurrentTraceInfo() {
var threadPool = getServiceComponents().threadPool();

Expand Down