Skip to content

Add busy assertion to avoid race condition for testStalledShardMigration #140230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mamazzol merged 1 commit into from
Jan 7, 2026
Merged

Add busy assertion to avoid race condition for testStalledShardMigration #140230

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .../qa/multi-node/src/javaRestTest/java/org/elasticsearch/xpack/shutdown/NodeShutdownIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,7 +325,7 @@ public void testStalledShardMigrationProperlyDetected() throws Exception {

// Mark the node for shutdown
putNodeShutdown(nodeIdToShutdown, "remove");
{
assertBusy(() -> {
// Now check the shard migration status
Request getStatusRequest = new Request("GET", "_nodes/" + nodeIdToShutdown + "/shutdown");
Response statusResponse = client().performRequest(getStatusRequest);
Expand All @@ -340,7 +340,7 @@ public void testStalledShardMigrationProperlyDetected() throws Exception {
)
);
assertThat(ObjectPath.eval("nodes.0.shard_migration.node_allocation_decision", status), notNullValue());
}
});

// Now update the allocation requirements to unblock shard relocation
Request updateSettingsRequest = new Request("PUT", indexName + "/_settings");
Expand Down